Bug 147472

Summary:

[patch] port security/openvpn replace "bash" with "sh" in easy-rsa scripts

Product:

Ports & Packages

Reporter:

Olli Hauer <ohauer>

Component:

Individual Port(s)

Assignee:

Matthias Andree <mandree>

Status:

Closed FIXED

Severity:

Affects Only Me

CC:

ohauer

Priority:

Normal

Version:

Latest

Hardware:

Any

OS:

Any

Attachments:

Description	Flags
patch_openvpn_Makefile.txt	none
ports_security_openvpn.patch	none

Description Olli Hauer 2010-06-04 16:20:00 UTC

scripts in easy-rsa use /bin/bash instead off /bin/sh, this patch fix this.
openvpn-devel is not affected, here /bin/sh is used.

Comment 1 Edwin Groothuis freebsd_committer

2010-06-04 16:21:50 UTC

Responsible Changed
From-To: freebsd-ports-bugs->mandree

Over to maintainer (via the GNATS Auto Assign Tool)

Comment 2 Matthias Andree freebsd_committer

2010-06-04 23:29:25 UTC

Hi Olli,

Thanks for your submission.
I will commit a different patch instead (attached).

- actually also fix the one remaining bashism (source ./vars => . ./vars)

- only deal with the easy-rsa/?.0 (1.0 and 2.0) directories, but leave
  Windows alone

- use find ... -exec ... '{}' + form rather than ... '{}' \;
  (more efficient, fewer sed invocations)

Best regards
Matthias

Comment 3 Matthias Andree freebsd_committer

2010-06-05 00:01:30 UTC

I've made an upstream patch (against the OpenVPN 2.1 branch in SVN)
to openvpn-devel@ for inclusion.

Comment 4 dfilter service freebsd_committer

2010-06-05 15:12:48 UTC

mandree     2010-06-05 14:12:29 UTC

  FreeBSD ports repository

  Modified files:
    security/openvpn     Makefile 
  Log:
  Fix bashisms (source FILE -> . FILE)
  replace shebang-lines /bin/bash -> /bin/sh
  bump portrevision (changed files)
  
  based on:
  PR: ports/147472
  Submitted by: Olli Hauer <ohauer@gmx.de>
  
  Approved by: miwi (mentor)
  
  Revision  Changes    Path
  1.42      +4 -0      ports/security/openvpn/Makefile
_______________________________________________
cvs-all@freebsd.org mailing list
http://lists.freebsd.org/mailman/listinfo/cvs-all
To unsubscribe, send any mail to "cvs-all-unsubscribe@freebsd.org"

Comment 5 Matthias Andree freebsd_committer

2010-06-05 15:12:56 UTC

State Changed
From-To: open->closed

Committed, with minor changes. Thanks!