Bug 147472 - [patch] port security/openvpn replace "bash" with "sh" in easy-rsa scripts
Summary: [patch] port security/openvpn replace "bash" with "sh" in easy-rsa scripts
Status: Closed FIXED
Alias: None
Product: Ports & Packages
Classification: Unclassified
Component: Individual Port(s) (show other bugs)
Version: Latest
Hardware: Any Any
: Normal Affects Only Me
Assignee: Matthias Andree
URL:
Keywords:
Depends on:
Blocks:
 
Reported: 2010-06-04 16:20 UTC by Olli Hauer
Modified: 2010-06-05 15:20 UTC (History)
1 user (show)

See Also:

Attachments
patch_openvpn_Makefile.txt (251 bytes, text/plain)
2010-06-04 16:20 UTC, Olli Hauer 		no flags Details
ports_security_openvpn.patch (763 bytes, patch)
2010-06-04 23:29 UTC, Matthias Andree 		no flags Details | Diff
View All Add an attachment (proposed patch, testcase, etc.)

Note You need to log in before you can comment on or make changes to this bug.
Description Olli Hauer 2010-06-04 16:20:00 UTC 
scripts in easy-rsa use /bin/bash instead off /bin/sh, this patch fix this.
openvpn-devel is not affected, here /bin/sh is used.
Comment 1 Edwin Groothuis freebsd_committer freebsd_triage 2010-06-04 16:21:50 UTC 
Responsible Changed
From-To: freebsd-ports-bugs->mandree

Over to maintainer (via the GNATS Auto Assign Tool)
Comment 2 Matthias Andree freebsd_committer freebsd_triage 2010-06-04 23:29:25 UTC 
Hi Olli,

Thanks for your submission.
I will commit a different patch instead (attached).

- actually also fix the one remaining bashism (source ./vars => . ./vars)

- only deal with the easy-rsa/?.0 (1.0 and 2.0) directories, but leave
  Windows alone

- use find ... -exec ... '{}' + form rather than ... '{}' \;
  (more efficient, fewer sed invocations)

Best regards
Matthias
Comment 3 Matthias Andree freebsd_committer freebsd_triage 2010-06-05 00:01:30 UTC 
I've made an upstream patch (against the OpenVPN 2.1 branch in SVN)
to openvpn-devel@ for inclusion.
Comment 4 dfilter service freebsd_committer freebsd_triage 2010-06-05 15:12:48 UTC 
mandree     2010-06-05 14:12:29 UTC

  FreeBSD ports repository

  Modified files:
    security/openvpn     Makefile 
  Log:
  Fix bashisms (source FILE -> . FILE)
  replace shebang-lines /bin/bash -> /bin/sh
  bump portrevision (changed files)
  
  based on:
  PR: ports/147472
  Submitted by: Olli Hauer <ohauer@gmx.de>
  
  Approved by: miwi (mentor)
  
  Revision  Changes    Path
  1.42      +4 -0      ports/security/openvpn/Makefile
_______________________________________________
cvs-all@freebsd.org mailing list
http://lists.freebsd.org/mailman/listinfo/cvs-all
To unsubscribe, send any mail to "cvs-all-unsubscribe@freebsd.org"
Comment 5 Matthias Andree freebsd_committer freebsd_triage 2010-06-05 15:12:56 UTC 
State Changed
From-To: open->closed

Committed, with minor changes. Thanks!