Bug 158127

Summary:

remount_optional option in rc.initdiskless doesn't actually work

Product:

Base System

Reporter:

Brian Olsen <brian>

Component:

conf

Assignee:

freebsd-rc (Nobody) <rc>

Status:

Open ---

Severity:

Affects Only Me

CC:

Alexander88207

Priority:

Normal

Keywords:

patch

Version:

Unspecified

Hardware:

Any

OS:

Any

Attachments:

Description	Flags
file.diff	none

Description Brian Olsen 2011-06-21 17:00:22 UTC

When trying to use the remount_optional option on a nanobsd like build that was going to run from an iso image with an optional remount of /dev/ufs/cfg onto /conf/default/etc I discovered that it doesn't actually work.

When remount_optional is present it will always print the error message "mount -o ro /dev/ufs/cfg /conf/default/etc failed: ignoring due to remount_optional" even when the mount succeeds. And when the mount fails it still drops into a shell.

A simple fix to the problem is attached.

Fix: Patch attached with submission follows:

Comment 1 Mark Linimon freebsd_committer

2011-06-23 19:12:03 UTC

Responsible Changed
From-To: freebsd-bugs->freebsd-rc

Over to maintainer(s).

Comment 2 Mark Linimon 2012-06-20 07:01:04 UTC

----- Forwarded message from Dewayne <dewayne.geraghty@heuristicsystems.com.au> -----

Date: Wed, 20 Jun 2012 06:19:55 +1000
From: Dewayne <dewayne.geraghty@heuristicsystems.com.au>
To: stable@freebsd.org
Cc: brian@maven-group.org
Subject: Diskless ignore remount - fix (Re: conf/158127: [patch]
	remount_optional option in rc.initdiskless doesn&#39;
	t actually work)

I notice that PR 158127 remains outstanding, June, 2011.  I've enclosed a
patch for Stable 9.0, to correct diskless booting.  When a mountpoint
fails, the failure may be ignored as required/documented.

--- /tmp/rc.initdiskless        2012-06-19 19:01:33.000000000 +1000
+++ /etc/rc.initdiskless        2012-06-19 19:02:16.000000000 +1000
@@ -166,7 +166,7 @@
 chkerr() {
     lastitem () ( n=$(($# - 1)) ; shift $n ; echo $1 )
     mountpoint="$(lastitem $2)"
-    [ -r $mountpoint/remount_optional ] && ( echo "$2 failed: ignoring due
to remount_optional" ; return )
+    [ -r $mountpoint/remount_optional ] && echo "$2 failed: ignoring due
to remount_optional" && return
     case $1 in
     0)

The patch has been tested with/without /conf/default/etc/remount_optional &
is functionally correct. 

It would be appreciated if someone would verify and commit.

Regards, Dewayne.
PS My apologies if Outlook has corrupted the patches appearance,we have to
work with what we've got.

----- End forwarded message -----

Comment 3 Eitan Adler freebsd_committer

2017-12-31 07:59:24 UTC

For bugs matching the following criteria:

Status: In Progress Changed: (is less than) 2014-06-01

Reset to default assignee and clear in-progress tags.

Mail being skipped

Comment 4 Graham Perrin freebsd_committer

2022-10-17 12:39:36 UTC

Keyword: 

    patch
or  patch-ready

– in lieu of summary line prefix: 

    [patch]

* bulk change for the keyword
* summary lines may be edited manually (not in bulk). 

Keyword descriptions and search interface: 

    <https://bugs.freebsd.org/bugzilla/describekeywords.cgi>

Comment 5 Mark Linimon freebsd_committer

2025-01-25 07:41:08 UTC

^Triage: note that the PR contains an inline patch.