Bug 162303

New patch:
http://elizabeth.twbbs.org/~buganini/fgrun.patch.txt

remove dependency on x11-toolkits/plib, according to
http://ncu.dl.sourceforge.net/project/fgrun/fgrun/1.6.0/NEWS

Comment 2 Ganael LAPLANCHE 2011-11-07 08:57:08 UTC

Responsible Changed
From-To: freebsd-ports-bugs->martymac

I will take care of it.

Comment 3 Ganael LAPLANCHE 2011-11-09 15:14:14 UTC

Hi,

Thanks a lot for your patch.

Unfortunately, it does not build out-of-the box on my Tinderbox because
fgrun needs boost-libs to be built. I've added this dependency as
BUILD_DEPENDS and tuned CONFIGURE_ARGS to help the configure script to
find boost.

Find a new version of your patch attached.

Please tell me if you agree with those changes.

Best regards,

--
Ganael LAPLANCHE <ganael.laplanche@martymac.org>
http://www.martymac.org | http://contribs.martymac.org
FreeBSD: martymac <martymac@FreeBSD.org>, http://www.FreeBSD.org

Thanks, but is plib still needed?

2011/11/9 Ganael LAPLANCHE <martymac@freebsd.org>:
> Hi,
>
> Thanks a lot for your patch.
>
> Unfortunately, it does not build out-of-the box on my Tinderbox because
> fgrun needs boost-libs to be built. I've added this dependency as
> BUILD_DEPENDS and tuned CONFIGURE_ARGS to help the configure script to
> find boost.
>
> Find a new version of your patch attached.
>
> Please tell me if you agree with those changes.
>
> Best regards,
>
> --
> Ganael LAPLANCHE <ganael.laplanche@martymac.org>
> http://www.martymac.org | http://contribs.martymac.org
> FreeBSD: martymac <martymac@FreeBSD.org>, http://www.FreeBSD.org
>

Comment 5 Ganael LAPLANCHE 2011-11-09 16:04:57 UTC

On Wed, 9 Nov 2011 15:30:17 GMT, Buganini wrote

>  Thanks, but is plib still needed?

Sorry, I had not seen your second patch. Indeed, plib does not seem to
be needed anymore. See my build logs here :

http://tinderbox.martymac.org/tb/index.php?action=describe_port&id=358

A new version of the patch is attached to this mail.

Would you agree with it ?

Best regards,

--
Ganael LAPLANCHE <ganael.laplanche@martymac.org>
http://www.martymac.org | http://contribs.martymac.org
FreeBSD: martymac <martymac@FreeBSD.org>, http://www.FreeBSD.org

Sure, thanks!

2011/11/10 Ganael LAPLANCHE <martymac@freebsd.org>:
> On Wed, 9 Nov 2011 15:30:17 GMT, Buganini wrote
>
>> =C2=A0Thanks, but is plib still needed?
>
> Sorry, I had not seen your second patch. Indeed, plib does not seem to
> be needed anymore. See my build logs here :
>
> http://tinderbox.martymac.org/tb/index.php?action=3Ddescribe_port&id=3D35=
8
>
> A new version of the patch is attached to this mail.
>
> Would you agree with it ?
>
> Best regards,
>
> --
> Ganael LAPLANCHE <ganael.laplanche@martymac.org>
> http://www.martymac.org | http://contribs.martymac.org
> FreeBSD: martymac <martymac@FreeBSD.org>, http://www.FreeBSD.org
>

Comment 7 dfilter service 2011-11-10 07:40:39 UTC

martymac    2011-11-10 07:40:25 UTC

  FreeBSD ports repository

  Modified files:
    games/fgrun          Makefile distinfo 
    games/fgrun/files    patch-src-Makefile.in 
  Log:
  - Update to 1.6.0
  - Remove obsolete dependency to plib
  - Add build dependency to boost-libs
  
  PR:             ports/162303
  Submitted by:   Kuan-Chung Chiu <buganini@gmail.com>
  Feature safe:   yes
  
  Revision  Changes    Path
  1.12      +7 -8      ports/games/fgrun/Makefile
  1.6       +2 -2      ports/games/fgrun/distinfo
  1.2       +1 -1      ports/games/fgrun/files/patch-src-Makefile.in
_______________________________________________
cvs-all@freebsd.org mailing list
http://lists.freebsd.org/mailman/listinfo/cvs-all
To unsubscribe, send any mail to "cvs-all-unsubscribe@freebsd.org"

Comment 8 Ganael LAPLANCHE 2011-11-10 07:57:36 UTC

State Changed
From-To: open->closed

Committed with minor changes, thanks!