Bug 167380

Summary: updated net/netatalk 2.2.2 breaks file transfers due to incorrect use of sendfile
Product: Ports & Packages Reporter: Daniel Becker <razzfazz>
Component: Individual Port(s)Assignee: Joe Marcus Clarke <marcus>
Status: Closed FIXED    
Severity: Affects Only Me    
Priority: Normal    
Version: Latest   
Hardware: Any   
OS: Any   
Attachments:
Description Flags
file.txt none

Description Daniel Becker 2012-04-27 23:10:10 UTC 
After the recent update to version 2.2.2, all file transfers that use sendfile return corrupt data and/or terminate the connection.

This appears to be a known issue in 2.2.2 that is caused by improper use of FreeBSD's sendfile; it was fixed upstream on Feb 9:

<http://netatalk.git.sourceforge.net/git/gitweb.cgi?p=netatalk/netatalk;a=commit;h=d24a954821229e8835acb6d629ef1f09a4441e8b>

This will apparently be rolled into 2.2.3 upstream; however, since 2.2.2 in its current state for all intents and purposes does not work on FreeBSD, please consider integrating the linked patch into the FreeBSD port.

Fix: Backport patch from upstream:

<http://netatalk.git.sourceforge.net/git/gitweb.cgi?p=netatalk/netatalk;a=commit;h=d24a954821229e8835acb6d629ef1f09a4441e8b>


Patch attached with submission follows:
How-To-Repeat: Read any file larger than a few kilobytes from a Netatalk share.
Comment 1 Edwin Groothuis freebsd_committer freebsd_triage 2012-04-28 21:21:37 UTC 
Responsible Changed
From-To: freebsd-ports-bugs->marcus

Over to maintainer (via the GNATS Auto Assign Tool)
Comment 2 Joe Marcus Clarke freebsd_committer freebsd_triage 2012-04-29 01:48:44 UTC 
State Changed
From-To: open->closed

Committed, thanks!
Comment 3 dfilter service freebsd_committer freebsd_triage 2012-04-29 01:48:49 UTC 
marcus      2012-04-29 00:48:35 UTC

  FreeBSD ports repository

  Added files:
    net/netatalk/files   patch-libatalk_adouble_ad_sendfile.c 
  Log:
  Fix usage of sendfile on FreeBSD.
  
  PR:             167380
  Submitted by:   Daniel Becker <razzfazz@gmail.com>
  Obtained from:  netatalk git
  
  Revision  Changes    Path
  1.1       +20 -0     ports/net/netatalk/files/patch-libatalk_adouble_ad_sendfile.c (new)
_______________________________________________
cvs-all@freebsd.org mailing list
http://lists.freebsd.org/mailman/listinfo/cvs-all
To unsubscribe, send any mail to "cvs-all-unsubscribe@freebsd.org"