Bug 173614
| Summary: | /etc/periodic/daily/404.status.zfs wrong | ||
|---|---|---|---|
| Product: | Base System | Reporter: | peter håkanson <peter> |
| Component: | conf | Assignee: | freebsd-bugs (Nobody) <bugs> |
| Status: | Open --- | ||
| Severity: | Affects Only Me | CC: | Alexander88207, asomers, wout |
| Priority: | Normal | ||
| Version: | Unspecified | ||
| Hardware: | Any | ||
| OS: | Any | ||
11-RELEASE version of 404.status-zfs returns `2` when a problem with ZFS is detected. I think this should return `3` like 406.status-gmirror and 401.status-graid do. This will make sure the output is sent when using: daily_show_success="NO" daily_show_info="NO" Are you sure? It looks to me like it will return rc=1 for a damaged pool. My comment above has a mistake: 404.status-zfs in 11-RELEASE does indeed return rc=1 (instead of rc=2) when a damaged (or no) pool is detected. However, people who now set daily_show_success=NO and daily_show_info=NO will not get any notification for broken pools. Other status periodic scripts, as 406.status-gmirror and 401.status-graid return rc=3 in this case, so the information is not masked in the periodic output. For bugs matching the following conditions: - Status == In Progress - Assignee == "bugs@FreeBSD.org" - Last Modified Year <= 2017 Do - Set Status to "Open" Keyword:
patch
or patch-ready
– in lieu of summary line prefix:
[patch]
* bulk change for the keyword
* summary lines may be edited manually (not in bulk).
Keyword descriptions and search interface:
<https://bugs.freebsd.org/bugzilla/describekeywords.cgi>
|
The 404.status.zfs does not report a broken vdev. Attatched is a modified 404.status.zfs that work both on a broken vdev and a correct one Fix: #!/bin/sh # # $FreeBSD: src/etc/periodic/daily/404.status-zfs,v 1.1.10.1.6.1 2010/12/21 17:09:25 kensmith Exp $ # made working by peter h IPSec 2012 # # If there is a global system configuration file, suck it in. # if [ -r /etc/defaults/periodic.conf ] then . /etc/defaults/periodic.conf source_periodic_confs fi case "$daily_status_zfs_enable" in [Yy][Ee][Ss]) echo echo 'Checking status of zfs pools:' out=`zpool status -x` echo "$out" # assume fail rc=1 # zpool status -x always exits with 0, so we have to interpret its # output to see what's going on. if ( echo $out | grep -q "state: DEGRADED" ) ; then rc=1 fi if ( echo $out | grep -q "all pools are healthy" ) ; then rc=0 fi ;; *) rc=0 ;; esac exit $rc How-To-Repeat: use it on a machine with zfs