Bug 186879
| Summary: | [PATCH] textproc/rarian: De-bashify | ||||||||||
|---|---|---|---|---|---|---|---|---|---|---|---|
| Product: | Ports & Packages | Reporter: | christian.mangin | ||||||||
| Component: | Individual Port(s) | Assignee: | Mateusz Piotrowski <0mp> | ||||||||
| Status: | Closed Not Accepted | ||||||||||
| Severity: | Affects Only Me | CC: | 0mp, ajacoutot, bapt, jan.kokemueller, w.schwarzenfeld | ||||||||
| Priority: | Normal | Keywords: | patch-ready | ||||||||
| Version: | Latest | ||||||||||
| Hardware: | Any | ||||||||||
| OS: | Any | ||||||||||
| Attachments: |
|
||||||||||
|
Description
christian.mangin
2014-02-18 21:10:00 UTC
Responsible Changed From-To: freebsd-ports-bugs->gnome Over to maintainer (via the GNATS Auto Assign Tool) I have missed a bit of some bashism like: #0:@: Second it will be a good idea to upstream that first Created attachment 149235 [details]
Patch to remove bash dependency from rarian
Thank you for looking at this patch :)
I've updated the patch to apply against the current version in ports.
As a remark the expression ${x##0:@:} _is_ compatible with sh. It's just a parameter expansion to remove the prefix '0:@:' from the value of the variable $x. I dont think '@' has any special meaning in this case.
But don't spend too much time on that since the scripts:
- rarian-sk-rebuild
- rarian-sk-update
are complete no-ops. They don't do anything. Zero. Nothing.
They're just there for decoration it seems.
But they do depend on bash.
As for the 2 other scripts:
- rarian-sk-config doesn't do much. It just print directories.
- rarian-sk-extract is just a simple wrapper around xsltproc.
In both case the switch to sh is trivial.
So all in all, rarian depends on bash for very little reasons.
Please note that upstream seems dormant since 2008. It looks that no bug
reports have been processed in the last 6 years.
No reply since 2014-11-10. Could this closed? It would be great if rarian could drop its bash dependency. It is the only reason bash gets installed on my machine. There has been no upstream release for more than 9 years. I don't think it is maintained anymore. However, rarian still is used by some gnome2/mate related doc packages and gets drawn in when installing Gimp or Gnumeric, for example. The patches converting the scripts to sh worked fine at the time this bug was opened. There haven't been too many changes to the port since, so I guess they'll still work. I'll try to apply the patch and post an updated version. Created attachment 189604 [details]
svn-diff-rarian
Maintainer feedback? (It is the question if it is a maintainer timeout). Add svn-diff. (Also think we don't need herre bash dependency). I'll take a look. I've given it a shot, but it is just too much work to really remove Bash dependency and keep the functionality of the port. checkbashisms reports a lot of problems even after applying the submitted patch. If you're still interested, I'm happy to integrate your patches here: https://github.com/0mp/rarian/. This might make them easier to handle. I'm closing the PR for now. Please let us know if you'd like to work on this. The branch which attempts to remove Bash is here: https://github.com/0mp/rarian/tree/bashisms |
