Bug 188149

Summary: [patch] sysutils/memtest86+: Doesn't build if ISO option is selected.
Product: Ports & Packages Reporter: Lawrence Chen <beastie>
Component: Individual Port(s)Assignee: Rodrigo Osorio <rodrigo>
Status: Closed FIXED    
Severity: Affects Only Me CC: avg, rodrigo
Priority: Normal    
Version: Latest   
Hardware: Any   
OS: Any   
Attachments:
Description Flags
patch none

Description Lawrence Chen 2014-03-31 21:40:00 UTC 
	
	sysutils/memtest86+ fails to build if the port option ISO is selected.

Fix: On closer look at the build failure, I saw this:

	make all
	make: illegal option -- -
	usage: make [-BPSXeiknpqrstv] [-C directory] [-D variable]
	        [-d flags] [-E variable] [-f makefile] [-I directory]
	        [-j max_jobs] [-m directory] [-V variable]
	        [variable=value] [target ...]
	gmake: *** [iso] Error 2
	gmake: *** Waiting for unfinished jobs....
	===> Compilation failed unexpectedly.

	We're using gmake, and the Makefile is calling make?
	
	Patch the Makefile to also use gmake.
Comment 1 Edwin Groothuis freebsd_committer freebsd_triage 2014-03-31 21:40:03 UTC 
Maintainer of sysutils/memtest86+,

Please note that PR ports/188149 has just been submitted.

If it contains a patch for an upgrade, an enhancement or a bug fix
you agree on, reply to this email stating that you approve the patch
and a committer will take care of it.

The full text of the PR can be found at:
    http://www.freebsd.org/cgi/query-pr.cgi?pr=ports/188149

-- 
Edwin Groothuis via the GNATS Auto Assign Tool
edwin@FreeBSD.org
Comment 2 Edwin Groothuis freebsd_committer freebsd_triage 2014-03-31 21:40:04 UTC 
State Changed
From-To: open->feedback

Awaiting maintainers feedback (via the GNATS Auto Assign Tool)
Comment 3 Andriy Gapon freebsd_committer freebsd_triage 2014-04-01 07:32:56 UTC 
Thank you for the report!
I have an alternative suggestion: instead of calling make all the 'iso' target
should just depend on 'all' target similarly to 'install' target.
-- 
Andriy Gapon
Comment 4 John Marino freebsd_committer freebsd_triage 2014-07-22 19:14:13 UTC 
Andriy, can you provide an updated patch?
Comment 5 Rodrigo Osorio freebsd_committer freebsd_triage 2015-01-04 10:17:27 UTC 
@Lawrence Chen  : Found the same issue, the patch works for me
@Andriy: the patch is minimal and sufficient

@maintainer: still waiting for approval, 9 months can be considered as a maintainer timeout
Comment 6 commit-hook freebsd_committer freebsd_triage 2015-01-25 11:46:28 UTC 
A commit references this bug:

Author: rodrigo
Date: Sun Jan 25 11:45:46 UTC 2015
New revision: 377883
URL: https://svnweb.freebsd.org/changeset/ports/377883

Log:
  Fix build when ISO option is selected.

  PR:		188149
  Submitted by:	Lawrence Chen <beastie@tardisi.com>

Changes:
  head/sysutils/memtest86+/files/patch-Makefile
Comment 7 Rodrigo Osorio freebsd_committer freebsd_triage 2015-01-25 11:47:40 UTC 
Committed with minor changes, thanks

@Andriy: you was right, I took your solution.

@maintainer: Timeout