sysutils/memtest86+ fails to build if the port option ISO is selected. Fix: On closer look at the build failure, I saw this: make all make: illegal option -- - usage: make [-BPSXeiknpqrstv] [-C directory] [-D variable] [-d flags] [-E variable] [-f makefile] [-I directory] [-j max_jobs] [-m directory] [-V variable] [variable=value] [target ...] gmake: *** [iso] Error 2 gmake: *** Waiting for unfinished jobs.... ===> Compilation failed unexpectedly. We're using gmake, and the Makefile is calling make? Patch the Makefile to also use gmake.
Maintainer of sysutils/memtest86+, Please note that PR ports/188149 has just been submitted. If it contains a patch for an upgrade, an enhancement or a bug fix you agree on, reply to this email stating that you approve the patch and a committer will take care of it. The full text of the PR can be found at: http://www.freebsd.org/cgi/query-pr.cgi?pr=ports/188149 -- Edwin Groothuis via the GNATS Auto Assign Tool edwin@FreeBSD.org
State Changed From-To: open->feedback Awaiting maintainers feedback (via the GNATS Auto Assign Tool)
Thank you for the report! I have an alternative suggestion: instead of calling make all the 'iso' target should just depend on 'all' target similarly to 'install' target. -- Andriy Gapon
Andriy, can you provide an updated patch?
@Lawrence Chen : Found the same issue, the patch works for me @Andriy: the patch is minimal and sufficient @maintainer: still waiting for approval, 9 months can be considered as a maintainer timeout
A commit references this bug: Author: rodrigo Date: Sun Jan 25 11:45:46 UTC 2015 New revision: 377883 URL: https://svnweb.freebsd.org/changeset/ports/377883 Log: Fix build when ISO option is selected. PR: 188149 Submitted by: Lawrence Chen <beastie@tardisi.com> Changes: head/sysutils/memtest86+/files/patch-Makefile
Committed with minor changes, thanks @Andriy: you was right, I took your solution. @maintainer: Timeout