Bug 191152
| Summary: | [NEW PORT] x11-fonts/hasklig | ||||||||||
|---|---|---|---|---|---|---|---|---|---|---|---|
| Product: | Ports & Packages | Reporter: | Gleb Popov <arrowd> | ||||||||
| Component: | Individual Port(s) | Assignee: | freebsd-ports-bugs (Nobody) <ports-bugs> | ||||||||
| Status: | Closed FIXED | ||||||||||
| Severity: | Affects Only Me | CC: | rakuco | ||||||||
| Priority: | --- | ||||||||||
| Version: | Latest | ||||||||||
| Hardware: | Any | ||||||||||
| OS: | Any | ||||||||||
| Attachments: |
|
||||||||||
> DISTNAME=Hasklig-${PORTVERSION} Missing a tab here. > BUILD_DEPENDS=fc-cache:${PORTSDIR}/x11-fonts/fontconfig > RUN_DEPENDS:= ${BUILD_DEPENDS} I believe fontconfig can be declared as a runtime dependency only, as it is only invoked when the port is installed and deinstalled. In any case, the second assignment could be a normal one, since nothing else changes BUILD_DEPENDS. > @unexec /bin/rm %D/%%FONTSDIR%%/fonts.cache-1 2>/dev/null || /usr/bin/true > @dirrm %%FONTSDIR%% > @exec %%LOCALBASE%%/bin/fc-cache -f -v %D/%%FONTSDIR%% || /usr/bin/true Please use the @fc keyword instead: http://www.freebsd.org/doc/en_US.ISO8859-1/books/porters-handbook/plist-keywords.html (In reply to Raphael Kubo da Costa from comment #1) > > DISTNAME=Hasklig-${PORTVERSION} > > Missing a tab here. > > > BUILD_DEPENDS=fc-cache:${PORTSDIR}/x11-fonts/fontconfig > > RUN_DEPENDS:= ${BUILD_DEPENDS} > > I believe fontconfig can be declared as a runtime dependency only, as it is > only invoked when the port is installed and deinstalled. In any case, the > second assignment could be a normal one, since nothing else changes > BUILD_DEPENDS. > > > @unexec /bin/rm %D/%%FONTSDIR%%/fonts.cache-1 2>/dev/null || /usr/bin/true > > @dirrm %%FONTSDIR%% > > @exec %%LOCALBASE%%/bin/fc-cache -f -v %D/%%FONTSDIR%% || /usr/bin/true > > Please use the @fc keyword instead: > http://www.freebsd.org/doc/en_US.ISO8859-1/books/porters-handbook/plist- > keywords.html I've stolen this Makefile from x11-fonts/ubuntu-font. And, BTW, i still have no idea how fontconfig gets run on install. Ok, i'll fix your points and attach a new patch. > And, BTW, i still have no idea how fontconfig gets run on install.
You can see how this is implemented by looking at Keywords/fc.yaml.
Created attachment 144139 [details]
Archive with new port
Updated port.
(In reply to Raphael Kubo da Costa from comment #1) > > BUILD_DEPENDS=fc-cache:${PORTSDIR}/x11-fonts/fontconfig > > RUN_DEPENDS:= ${BUILD_DEPENDS} > > I believe fontconfig can be declared as a runtime dependency only, as it is > only invoked when the port is installed and deinstalled. In any case, the > second assignment could be a normal one, since nothing else changes > BUILD_DEPENDS. I didn't see any change in this part, even though the port built fine here without the BUILD_DEPENDS line. Have you given it any thought? Created attachment 144186 [details]
Archive with new port
Ah, sorry, missed it.
I'm going to commit a version that moves DISTNAME one line up and uses RUN_DEPENDS= instead of RUN_DEPENDS:= (I've explained the difference between those two before). Please run portlint before submitting. A commit references this bug: Author: rakuco Date: Fri Jun 27 17:09:44 UTC 2014 New revision: 359584 URL: http://svnweb.freebsd.org/changeset/ports/359584 Log: Add x11-fonts/hasklig. Hasklig is a Haskell code font with monospaced ligatures based on Source Code Pro font. It adds nice representations of such operators like (->), (>>=), (-<) and so on. WWW: http://github.com/i-tu/Hasklig PR: 191152 Submitted by: arrowdodger <6yearold@gmail.com> Changes: head/x11-fonts/Makefile head/x11-fonts/hasklig/ head/x11-fonts/hasklig/Makefile head/x11-fonts/hasklig/distinfo head/x11-fonts/hasklig/pkg-descr head/x11-fonts/hasklig/pkg-plist |
Created attachment 143896 [details] Archive with new port