Bug 192693
| Summary: | LPRng startup script does not use correct paths for required files | ||||||||
|---|---|---|---|---|---|---|---|---|---|
| Product: | Ports & Packages | Reporter: | papowell | ||||||
| Component: | Individual Port(s) | Assignee: | John Marino <marino> | ||||||
| Status: | Closed FIXED | ||||||||
| Severity: | Affects Many People | CC: | ebay, marino | ||||||
| Priority: | --- | ||||||||
| Version: | Latest | ||||||||
| Hardware: | Any | ||||||||
| OS: | Any | ||||||||
| Attachments: |
|
||||||||
There's no maintainter, but lets see what the guy that provided the last two changes to LPRng says. Adam, is this submitter and his patch correct? Created attachment 145875 [details]
Use %%PREFIX%%/etc/(filename) in rc script and bump PORTREVISION
The initial patch has an extra /lpd/ in the config file path but the port doesn't use that path. New patch corrects it (tested) and bumps PORTREVISION. Thanks.
maintainer approves with an updated patch, move to patch-ready. A commit references this bug: Author: marino Date: Sat Aug 16 19:35:11 UTC 2014 New revision: 365126 URL: http://svnweb.freebsd.org/changeset/ports/365126 Log: sysutils/LPRng: Fix rc script path locations PR: 192693 Proposed fix: papowell (astart.com) Final fix: Adam McDougall Changes: head/sysutils/LPRng/Makefile head/sysutils/LPRng/files/lprng.in heh, obviously the "maintainer" didn't approve that, brain lapse. Anyway, it's fixed now. |
Created attachment 145847 [details] diff -u LPRng/files/lprng.in output port sysutils/LPRng revision 364866 in Makefile The files/lprng.in file is updated and copied to the start script directory, usually /usr/local/etc/rc.d/lprng. The lprng script checks for some files but in the current version uses %%SYSCONFDIR%%/xxx. Based on the current Makefile, these should be %%PREFIX%%/etc/lpd/xxx. See the attached DIFF for suggested changes.