Bug 192693 - LPRng startup script does not use correct paths for required files
Summary: LPRng startup script does not use correct paths for required files
Status: Closed FIXED
Alias: None
Product: Ports & Packages
Classification: Unclassified
Component: Individual Port(s) (show other bugs)
Version: Latest
Hardware: Any Any
: --- Affects Many People
Assignee: John Marino
URL:
Keywords:
Depends on:
Blocks:
 
Reported: 2014-08-15 23:06 UTC by papowell
Modified: 2014-08-16 19:36 UTC (History)
2 users (show)

See Also:


Attachments
diff -u LPRng/files/lprng.in output (379 bytes, patch)
2014-08-15 23:06 UTC, papowell
no flags Details | Diff
Use %%PREFIX%%/etc/(filename) in rc script and bump PORTREVISION (839 bytes, patch)
2014-08-16 16:13 UTC, Adam McDougall
no flags Details | Diff

Note You need to log in before you can comment on or make changes to this bug.
Description papowell 2014-08-15 23:06:31 UTC
Created attachment 145847 [details]
diff -u LPRng/files/lprng.in output

port sysutils/LPRng revision 364866 in Makefile

The files/lprng.in file is updated and copied to the start script directory, usually /usr/local/etc/rc.d/lprng.  The lprng script checks for some files but
in the current version uses %%SYSCONFDIR%%/xxx.  Based on the current Makefile, these should be %%PREFIX%%/etc/lpd/xxx.  See the attached DIFF for suggested changes.
Comment 1 John Marino freebsd_committer 2014-08-16 07:09:35 UTC
There's no maintainter, but lets see what the guy that provided the last two changes to LPRng says.

Adam, is this submitter and his patch correct?
Comment 2 Adam McDougall 2014-08-16 16:13:37 UTC
Created attachment 145875 [details]
Use %%PREFIX%%/etc/(filename) in rc script and bump PORTREVISION

The initial patch has an extra /lpd/ in the config file path but the port doesn't use that path.  New patch corrects it (tested) and bumps PORTREVISION.  Thanks.
Comment 3 John Marino freebsd_committer 2014-08-16 18:14:30 UTC
maintainer approves with an updated patch, move to patch-ready.
Comment 4 commit-hook freebsd_committer 2014-08-16 19:35:49 UTC
A commit references this bug:

Author: marino
Date: Sat Aug 16 19:35:11 UTC 2014
New revision: 365126
URL: http://svnweb.freebsd.org/changeset/ports/365126

Log:
  sysutils/LPRng: Fix rc script path locations

  PR:		192693
  Proposed fix:	papowell (astart.com)
  Final fix:	Adam McDougall

Changes:
  head/sysutils/LPRng/Makefile
  head/sysutils/LPRng/files/lprng.in
Comment 5 John Marino freebsd_committer 2014-08-16 19:36:32 UTC
heh, obviously the "maintainer" didn't approve that, brain lapse.

Anyway, it's fixed now.