Bug 194097
| Summary: | [patch update] glassfish-4.1 | ||||||||
|---|---|---|---|---|---|---|---|---|---|
| Product: | Ports & Packages | Reporter: | Enrico M. Crisostomo <enrico.m.crisostomo> | ||||||
| Component: | Individual Port(s) | Assignee: | Kurt Jaeger <pi> | ||||||
| Status: | Closed FIXED | ||||||||
| Severity: | Affects Some People | CC: | cjr, pi | ||||||
| Priority: | --- | Flags: | cjr:
maintainer-feedback+
|
||||||
| Version: | Latest | ||||||||
| Hardware: | Any | ||||||||
| OS: | Any | ||||||||
| Attachments: |
|
||||||||
Comment on attachment 147918 [details]
glassfish-4.1 update - SVN port diff
Maintainer agreed on my submitting the patch.
I'm running poudriere test builds right now. Hi Kurt, Thank you very much for progressing on this PR. Today I had to update this port because I found a bug and an improvement in the rc script: since the status is still "In Discussion", and since it's my very first port update, I hope you don't mind my doing this and attaching another svn patch (if I'm skipping some rule here, I'm not aware of it.) Thanks you and regards, -- Enrico Created attachment 148343 [details]
glassfish-4.1 update - SVN port diff - Update 2
Fixes an hardcoded path in the rc script.
Uses JAVA_HOME in the PATH instead of hard-coding /usr/local/bin.
A commit references this bug: Author: pi Date: Wed Oct 15 17:25:27 UTC 2014 New revision: 370937 URL: https://svnweb.freebsd.org/changeset/ports/370937 Log: www/glassfish: 3.1.2.2 -> 4.1 Changes since 3.1.2.2: https://glassfish.java.net/docs/4.0/release-notes.pdf https://glassfish.java.net/docs/4.1/release-notes.pdf PR: 194097 Submitted by: Enrico M. Crisostomo <enrico.m.crisostomo@gmail.com> Approved by: cjr@cruwe.de (maintainer) Changes: head/www/glassfish/Makefile head/www/glassfish/distinfo head/www/glassfish/files/glassfish.in head/www/glassfish/pkg-plist (In reply to Enrico M. Crisostomo from comment #4) > Created attachment 148343 [details] > glassfish-4.1 update - SVN port diff - Update 2 > > Fixes an hardcoded path in the rc script. > Uses JAVA_HOME in the PATH instead of hard-coding /usr/local/bin. Thanks, I used the updated patch, tested with poudriere, everythink looks fine, so: Committed. Thank you very much Kurt. |
Created attachment 147918 [details] glassfish-4.1 update - SVN port diff I've contacted the current glassfish port maintainer and he agrees on my submitting this port update. Attached you can find the svn diff.