Bug 195655

Summary: Fix multimedia/libvpx build with clang 3.5.0
Product: Ports & Packages Reporter: Dimitry Andric <dim>
Component: Individual Port(s)Assignee: Ashish SHUKLA <ashish>
Status: Closed FIXED    
Severity: Affects Many People CC: emaste, jmd
Priority: --- Flags: bugzilla: maintainer-feedback? (ashish)
Version: Latest   
Hardware: Any   
OS: Any   
Bug Depends on:    
Bug Blocks: 195480    
Attachments:
Description Flags
Fix multimedia/libvpx build with clang 3.5.0
none
Updated fix for multimedia/libvpx build with clang 3.5.0 none

Description Dimitry Andric freebsd_committer freebsd_triage 2014-12-03 21:49:26 UTC 
Created attachment 150154 [details]
Fix multimedia/libvpx build with clang 3.5.0

In bug 195480, I asked for an exp-run with clang 3.5.0.  One of the failures here is in multimedia/libvpx.

Since in this case the compiler is abused as a sort of text processor, it is easiest to use -no-integrated-as, as suggested here:

https://code.google.com/p/webm/issues/detail?id=729

This is fixed by a small change to patch-build_make_Makefile.

Additionally, libvpx's configure script incorrectly checks for x32, making it impossible to build the port on i386 with clang.  That is fixed by patch-build_make_configure.sh.  (This fix has also been sent upstream.)
Comment 1 Bugzilla Automation freebsd_committer freebsd_triage 2014-12-03 21:49:26 UTC 
Auto-assigned to maintainer ashish@FreeBSD.org
Comment 2 Dimitry Andric freebsd_committer freebsd_triage 2014-12-03 22:05:55 UTC 
*** Bug 195505 has been marked as a duplicate of this bug. ***
Comment 3 Dimitry Andric freebsd_committer freebsd_triage 2014-12-03 23:01:32 UTC 
Created attachment 150158 [details]
Updated fix for multimedia/libvpx build with clang 3.5.0

Here is an updated fix, that should also work correctly if ${CC} is gcc. This also ensures that clang is correctly detected by configure, so -fno-strict-aliasing is used (as mentioned in the script), and gcc-specific warning options are not used.
Comment 4 Ashish SHUKLA freebsd_committer freebsd_triage 2014-12-08 09:28:32 UTC 
Hi,

Thanks for the fix. It is committed in r374255[1]

Sorry for the poor commit message[2].

[1] https://svnweb.freebsd.org/ports?view=revision&revision=374255
[2] https://lists.freebsd.org/pipermail/svn-ports-head/2014-December/078855.html

Thanks
Ashish