Bug 195655 - Fix multimedia/libvpx build with clang 3.5.0
Summary: Fix multimedia/libvpx build with clang 3.5.0
Status: Closed FIXED
Alias: None
Product: Ports & Packages
Classification: Unclassified
Component: Individual Port(s) (show other bugs)
Version: Latest
Hardware: Any Any
: --- Affects Many People
Assignee: Ashish SHUKLA
URL:
Keywords:
: 195505 (view as bug list)
Depends on:
Blocks: 195480
  Show dependency tree / graph
 
Reported: 2014-12-03 21:49 UTC by Dimitry Andric
Modified: 2014-12-08 09:28 UTC (History)
2 users (show)

See Also:
bugzilla: maintainer-feedback? (ashish)

Attachments
Fix multimedia/libvpx build with clang 3.5.0 (1.67 KB, patch)
2014-12-03 21:49 UTC, Dimitry Andric 		no flags Details | Diff
Updated fix for multimedia/libvpx build with clang 3.5.0 (3.37 KB, patch)
2014-12-03 23:01 UTC, Dimitry Andric 		no flags Details | Diff
Show Obsolete (1) View All Add an attachment (proposed patch, testcase, etc.)

Note You need to log in before you can comment on or make changes to this bug.
Description Dimitry Andric freebsd_committer freebsd_triage 2014-12-03 21:49:26 UTC 
Created attachment 150154 [details]
Fix multimedia/libvpx build with clang 3.5.0

In bug 195480, I asked for an exp-run with clang 3.5.0.  One of the failures here is in multimedia/libvpx.

Since in this case the compiler is abused as a sort of text processor, it is easiest to use -no-integrated-as, as suggested here:

https://code.google.com/p/webm/issues/detail?id=729

This is fixed by a small change to patch-build_make_Makefile.

Additionally, libvpx's configure script incorrectly checks for x32, making it impossible to build the port on i386 with clang.  That is fixed by patch-build_make_configure.sh.  (This fix has also been sent upstream.)
Comment 1 Bugzilla Automation freebsd_committer freebsd_triage 2014-12-03 21:49:26 UTC 
Auto-assigned to maintainer ashish@FreeBSD.org
Comment 2 Dimitry Andric freebsd_committer freebsd_triage 2014-12-03 22:05:55 UTC 
*** Bug 195505 has been marked as a duplicate of this bug. ***
Comment 3 Dimitry Andric freebsd_committer freebsd_triage 2014-12-03 23:01:32 UTC 
Created attachment 150158 [details]
Updated fix for multimedia/libvpx build with clang 3.5.0

Here is an updated fix, that should also work correctly if ${CC} is gcc. This also ensures that clang is correctly detected by configure, so -fno-strict-aliasing is used (as mentioned in the script), and gcc-specific warning options are not used.
Comment 4 Ashish SHUKLA freebsd_committer freebsd_triage 2014-12-08 09:28:32 UTC 
Hi,

Thanks for the fix. It is committed in r374255[1]

Sorry for the poor commit message[2].

[1] https://svnweb.freebsd.org/ports?view=revision&revision=374255
[2] https://lists.freebsd.org/pipermail/svn-ports-head/2014-December/078855.html

Thanks
Ashish