Bug 195723

Summary: New port: net/megatools
Product: Ports & Packages Reporter: Max Kostikov <max>
Component: Individual Port(s)Assignee: Dmitry Marakasov <amdmi3>
Status: Closed FIXED    
Severity: Affects Many People CC: amdmi3
Priority: ---    
Version: Latest   
Hardware: Any   
OS: Any   
Attachments:
Description Flags
net/megatools directory
none
patched net/megatools directory
none
revision 2 net/megatools directory
none
revision 3 net/megatools directory
none
Suggested final set of changes
none
final net/megatools dir for commit
none
final megatools.shar none

Description Max Kostikov 2014-12-05 20:50:55 UTC
Created attachment 150246 [details]
net/megatools directory

Tools for MEGA.CO.NZ cloud drive
Comment 1 Max Kostikov 2014-12-05 21:59:58 UTC
Created attachment 150247 [details]
patched net/megatools directory
Comment 2 Max Kostikov 2014-12-08 16:23:48 UTC
Created attachment 150358 [details]
revision 2 net/megatools directory

Added dependencies and post-install message
Comment 3 Max Kostikov 2014-12-10 23:25:43 UTC
Created attachment 150442 [details]
revision 3 net/megatools directory

+ added FUSE option choise
Comment 4 Dmitry Marakasov freebsd_committer 2014-12-11 00:35:36 UTC
Created attachment 150450 [details]
Suggested final set of changes
Comment 5 Dmitry Marakasov freebsd_committer 2014-12-11 00:44:10 UTC
Well I have some more suggestions, and to speed things up, I'll just show them here. If you're okay with them, I can commit this right away. Most of them were suggested by portlint (ports-mgmt/portlint) - though it has many false positives, you should check its output as well as stage-qa.

- Remove PORTREVISION, new ports shouldn't set it
- Add LICENSE_FILE (it's presence is preferred)
- Place statements in more canonical order (not sure if that's documented, but you may look at other ports)
- Add USE_LDCONFIG as it installs shared libraries (portlint)
- Fix pkgconfig file installation path (portlint)
- Remove pkg-message - ports which install manpages are very common, there's no need to remind user of them in any particular port
- Remove FUSE_DESC. FUSE is standard options which already has suitable description (see ports/Mk/bsd.options.desc.mk)
- Make FUSE option enabled by default
- Use OPTIONS_SUB, which adds %%FUSE%% plist substitude for you, making conditional check needless; change plist accordingly
Comment 6 Max Kostikov 2014-12-11 06:39:40 UTC
Created attachment 150460 [details]
final net/megatools dir for commit

(In reply to Dmitry Marakasov from comment #5)
> Well I have some more suggestions, and to speed things up, I'll just show
> them here.

I just finished port changes according your recommendations.
It's looks similar to yours attached sample diff changes (see attachment).
Hope it will be ok to commit.
Thanks!
Comment 7 Max Kostikov 2014-12-11 06:43:20 UTC
Created attachment 150461 [details]
final megatools.shar
Comment 8 commit-hook freebsd_committer 2014-12-11 23:06:46 UTC
A commit references this bug:

Author: amdmi3
Date: Thu Dec 11 23:06:16 UTC 2014
New revision: 374555
URL: https://svnweb.freebsd.org/changeset/ports/374555

Log:
  Megatools is a collection of programs for accessing Mega
  service from a command line of your desktop or server.

  Megatools allow you to copy individual files as well as
  entire directory trees to and from the cloud. You can also
  perform streaming downloads for example to preview videos
  and audio files, without needing to download the entire
  file.

  WWW: http://megatools.megous.com/

  PR:		195723
  Submitted by:	max@kostikov.co

Changes:
  head/net/Makefile
  head/net/megatools/
  head/net/megatools/Makefile
  head/net/megatools/distinfo
  head/net/megatools/pkg-descr
  head/net/megatools/pkg-plist