Bug 195798
| Summary: | devel/fb303: Fix pkg-plist | ||||||||
|---|---|---|---|---|---|---|---|---|---|
| Product: | Ports & Packages | Reporter: | Real Huang <realhuang21> | ||||||
| Component: | Individual Port(s) | Assignee: | John Marino <marino> | ||||||
| Status: | Closed Not Accepted | ||||||||
| Severity: | Affects Many People | CC: | bsdports, marino, realhuang21 | ||||||
| Priority: | --- | Keywords: | patch, patch-ready | ||||||
| Version: | Latest | ||||||||
| Hardware: | Any | ||||||||
| OS: | Any | ||||||||
| Attachments: |
|
||||||||
Comment on attachment 150335 [details]
the patch file
devel_fb303_pkg-plist.diff
the port is not maintained, the patch is doesn't come with a test log. However, it's only a pkg-plist change (which requires a PORTREVISION bump which is missing), so I'll move it to patch ready for further testing. Comment on attachment 150335 [details]
the patch file
Index: Makefile
===================================================================
--- Makefile (revision 374232)
+++ Makefile (working copy)
@@ -3,7 +3,7 @@
PORTNAME= fb303
PORTVERSION= ${THRIFT_PORTVERSION}
-PORTREVISION= 1
+PORTREVISION= 2
PORTEPOCH= 1
CATEGORIES= devel
MASTER_SITES= APACHE
Index: pkg-plist
===================================================================
--- pkg-plist (revision 374232)
+++ pkg-plist (working copy)
@@ -21,5 +21,8 @@
%%PYTHON_SITELIBDIR%%/fb303_scripts/__init__.pyc
%%PYTHON_SITELIBDIR%%/fb303_scripts/fb303_simple_mgmt.py
%%PYTHON_SITELIBDIR%%/fb303_scripts/fb303_simple_mgmt.pyc
-%%PYTHON_SITELIBDIR%%/thrift_fb303-1.0.0_dev-py%%PYTHON_VER%%.egg-info
+%%PYTHON_SITELIBDIR%%/thrift_fb303-1.0.0_dev-py%%PYTHON_VER%%.egg-info/PKG-INFO
+%%PYTHON_SITELIBDIR%%/thrift_fb303-1.0.0_dev-py%%PYTHON_VER%%.egg-info/SOURCES.txt
+%%PYTHON_SITELIBDIR%%/thrift_fb303-1.0.0_dev-py%%PYTHON_VER%%.egg-info/dependency_links.txt
+%%PYTHON_SITELIBDIR%%/thrift_fb303-1.0.0_dev-py%%PYTHON_VER%%.egg-info/top_level.txt
%%DATADIR%%/if/fb303.thrift
Created attachment 152152 [details]
pathfile.diff.svn
(In reply to John Marino from comment #2) Hi John, Sorry,I have update the PORTREVISION,thanks. Please do not add freebsd-ports@freebsd.org to the CC list (ever). I'm removing that mailing list address from CC now. This patch seems to be wrong. Look at the poudriere log after I apply it: ====> Running Q/A tests (stage-qa) ====> Checking for pkg-plist issues (check-plist) ===> Parsing plist ===> Checking for items in STAGEDIR missing from pkg-plist Error: Orphaned: %%PYTHON_SITELIBDIR%%/thrift_fb303-1.0.0_dev-py%%PYTHON_VER%%.egg-info ===> Checking for items in pkg-plist which are not in STAGEDIR Error: Missing: %%PYTHON_SITELIBDIR%%/thrift_fb303-1.0.0_dev-py%%PYTHON_VER%%.egg-info/PKG-INFO Error: Missing: %%PYTHON_SITELIBDIR%%/thrift_fb303-1.0.0_dev-py%%PYTHON_VER%%.egg-info/SOURCES.txt Error: Missing: %%PYTHON_SITELIBDIR%%/thrift_fb303-1.0.0_dev-py%%PYTHON_VER%%.egg-info/dependency_links.txt Error: Missing: %%PYTHON_SITELIBDIR%%/thrift_fb303-1.0.0_dev-py%%PYTHON_VER%%.egg-info/top_level.txt ===> Error: Plist issues found. *** Error code 1 I'm going to run this again without the patch, but it seems that the port was always ok. I ran the current fb303 port through poudriere and it passed just fine. I don't know why you think the patch is needed, but apparently it's something specific to your system. If you had run the port through poudriere in order to provide the "missing" test log I mentioned earlier, you would have seen there was no problem. I'm closing this PR as invalid. I try install devel/py-setuptools first,then install devel/fb303 can reproduce this bug... If you can't reproduce it in poudriere, there's nothing we can do. That's the critical test. |
Created attachment 150335 [details] the patch file The devel/fb303 pkg-plist 「%%PYTHON_SITELIBDIR%%/thrift_fb303-1.0.0_dev-py%%PYTHON_VER%%.egg-info」 is a directories. [PATCH] Index: pkg-plist =================================================================== --- pkg-plist (revision 374232) +++ pkg-plist (working copy) @@ -21,5 +21,8 @@ %%PYTHON_SITELIBDIR%%/fb303_scripts/__init__.pyc %%PYTHON_SITELIBDIR%%/fb303_scripts/fb303_simple_mgmt.py %%PYTHON_SITELIBDIR%%/fb303_scripts/fb303_simple_mgmt.pyc -%%PYTHON_SITELIBDIR%%/thrift_fb303-1.0.0_dev-py%%PYTHON_VER%%.egg-info +%%PYTHON_SITELIBDIR%%/thrift_fb303-1.0.0_dev-py%%PYTHON_VER%%.egg-info/PKG-INFO +%%PYTHON_SITELIBDIR%%/thrift_fb303-1.0.0_dev-py%%PYTHON_VER%%.egg-info/SOURCES.txt +%%PYTHON_SITELIBDIR%%/thrift_fb303-1.0.0_dev-py%%PYTHON_VER%%.egg-info/dependency_links.txt +%%PYTHON_SITELIBDIR%%/thrift_fb303-1.0.0_dev-py%%PYTHON_VER%%.egg-info/top_level.txt %%DATADIR%%/if/fb303.thrift