Bug 195798 - devel/fb303: Fix pkg-plist
Summary: devel/fb303: Fix pkg-plist
Status: Closed Not Accepted
Alias: None
Product: Ports & Packages
Classification: Unclassified
Component: Individual Port(s) (show other bugs)
Version: Latest
Hardware: Any Any
: --- Affects Many People
Assignee: John Marino
URL:
Keywords: patch, patch-ready
Depends on:
Blocks:
 
Reported: 2014-12-08 06:27 UTC by Real Huang
Modified: 2015-02-12 08:53 UTC (History)
3 users (show)

See Also:

Attachments
the patch file (792 bytes, patch)
2014-12-08 06:27 UTC, Bugzilla Automation 		no flags Details | Diff
pathfile.diff.svn (1.10 KB, patch)
2015-01-26 06:08 UTC, Real Huang 		no flags Details | Diff
Show Obsolete (1) View All Add an attachment (proposed patch, testcase, etc.)

Note You need to log in before you can comment on or make changes to this bug.
Description Real Huang 2014-12-08 06:27:19 UTC 
Created attachment 150335 [details]
the patch file

The devel/fb303 pkg-plist 「%%PYTHON_SITELIBDIR%%/thrift_fb303-1.0.0_dev-py%%PYTHON_VER%%.egg-info」

is a directories.

[PATCH]

Index: pkg-plist
===================================================================
--- pkg-plist   (revision 374232)
+++ pkg-plist   (working copy)
@@ -21,5 +21,8 @@
 %%PYTHON_SITELIBDIR%%/fb303_scripts/__init__.pyc
 %%PYTHON_SITELIBDIR%%/fb303_scripts/fb303_simple_mgmt.py
 %%PYTHON_SITELIBDIR%%/fb303_scripts/fb303_simple_mgmt.pyc
-%%PYTHON_SITELIBDIR%%/thrift_fb303-1.0.0_dev-py%%PYTHON_VER%%.egg-info
+%%PYTHON_SITELIBDIR%%/thrift_fb303-1.0.0_dev-py%%PYTHON_VER%%.egg-info/PKG-INFO
+%%PYTHON_SITELIBDIR%%/thrift_fb303-1.0.0_dev-py%%PYTHON_VER%%.egg-info/SOURCES.txt
+%%PYTHON_SITELIBDIR%%/thrift_fb303-1.0.0_dev-py%%PYTHON_VER%%.egg-info/dependency_links.txt
+%%PYTHON_SITELIBDIR%%/thrift_fb303-1.0.0_dev-py%%PYTHON_VER%%.egg-info/top_level.txt
 %%DATADIR%%/if/fb303.thrift
Comment 1 Real Huang 2015-01-19 06:10:46 UTC 
Comment on attachment 150335 [details]
the patch file

devel_fb303_pkg-plist.diff
Comment 2 John Marino freebsd_committer freebsd_triage 2015-01-25 18:37:33 UTC 
the port is not maintained, the patch is doesn't come with a test log.
However, it's only a pkg-plist change (which requires a PORTREVISION bump which is missing), so I'll move it to patch ready for further testing.
Comment 3 Real Huang 2015-01-26 06:07:07 UTC 
Comment on attachment 150335 [details]
the patch file

Index: Makefile
===================================================================
--- Makefile    (revision 374232)
+++ Makefile    (working copy)
@@ -3,7 +3,7 @@

 PORTNAME=      fb303
 PORTVERSION=   ${THRIFT_PORTVERSION}
-PORTREVISION=  1
+PORTREVISION=  2
 PORTEPOCH=     1
 CATEGORIES=    devel
 MASTER_SITES=  APACHE
Index: pkg-plist
===================================================================
--- pkg-plist   (revision 374232)
+++ pkg-plist   (working copy)
@@ -21,5 +21,8 @@
 %%PYTHON_SITELIBDIR%%/fb303_scripts/__init__.pyc
 %%PYTHON_SITELIBDIR%%/fb303_scripts/fb303_simple_mgmt.py
 %%PYTHON_SITELIBDIR%%/fb303_scripts/fb303_simple_mgmt.pyc
-%%PYTHON_SITELIBDIR%%/thrift_fb303-1.0.0_dev-py%%PYTHON_VER%%.egg-info
+%%PYTHON_SITELIBDIR%%/thrift_fb303-1.0.0_dev-py%%PYTHON_VER%%.egg-info/PKG-INFO
+%%PYTHON_SITELIBDIR%%/thrift_fb303-1.0.0_dev-py%%PYTHON_VER%%.egg-info/SOURCES.txt
+%%PYTHON_SITELIBDIR%%/thrift_fb303-1.0.0_dev-py%%PYTHON_VER%%.egg-info/dependency_links.txt
+%%PYTHON_SITELIBDIR%%/thrift_fb303-1.0.0_dev-py%%PYTHON_VER%%.egg-info/top_level.txt
 %%DATADIR%%/if/fb303.thrift
Comment 4 Real Huang 2015-01-26 06:08:39 UTC 
Created attachment 152152 [details]
pathfile.diff.svn
Comment 5 Real Huang 2015-01-26 06:12:40 UTC 
(In reply to John Marino from comment #2)
Hi John,

Sorry,I have update the PORTREVISION,thanks.
Comment 6 John Marino freebsd_committer freebsd_triage 2015-01-26 08:12:40 UTC 
Please do not add freebsd-ports@freebsd.org to the CC list (ever).
I'm removing that mailing list address from CC now.
Comment 7 John Marino freebsd_committer freebsd_triage 2015-02-06 09:32:12 UTC 
This patch seems to be wrong.  Look at the poudriere log after I apply it:

====> Running Q/A tests (stage-qa)
====> Checking for pkg-plist issues (check-plist)
===> Parsing plist
===> Checking for items in STAGEDIR missing from pkg-plist
Error: Orphaned: %%PYTHON_SITELIBDIR%%/thrift_fb303-1.0.0_dev-py%%PYTHON_VER%%.egg-info
===> Checking for items in pkg-plist which are not in STAGEDIR
Error: Missing: %%PYTHON_SITELIBDIR%%/thrift_fb303-1.0.0_dev-py%%PYTHON_VER%%.egg-info/PKG-INFO
Error: Missing: %%PYTHON_SITELIBDIR%%/thrift_fb303-1.0.0_dev-py%%PYTHON_VER%%.egg-info/SOURCES.txt
Error: Missing: %%PYTHON_SITELIBDIR%%/thrift_fb303-1.0.0_dev-py%%PYTHON_VER%%.egg-info/dependency_links.txt
Error: Missing: %%PYTHON_SITELIBDIR%%/thrift_fb303-1.0.0_dev-py%%PYTHON_VER%%.egg-info/top_level.txt
===> Error: Plist issues found.
*** Error code 1


I'm going to run this again without the patch, but it seems that the port was always ok.
Comment 8 John Marino freebsd_committer freebsd_triage 2015-02-06 09:35:48 UTC 
I ran the current fb303 port through poudriere and it passed just fine.

I don't know why you think the patch is needed, but apparently it's something specific to your system.  If you had run the port through poudriere in order to provide the "missing" test log I mentioned earlier, you would have seen there was no problem.

I'm closing this PR as invalid.
Comment 9 Real Huang 2015-02-12 08:43:31 UTC 
I try install devel/py-setuptools first,then install devel/fb303 can reproduce this bug...
Comment 10 John Marino freebsd_committer freebsd_triage 2015-02-12 08:53:51 UTC 
If you can't reproduce it in poudriere, there's nothing we can do.  That's the critical test.