Bug 195809

Summary: deskutils/virt-manager: broken patch
Product: Ports & Packages Reporter: Dmitry Marakasov <amdmi3>
Component: Individual Port(s)Assignee: Jason Helfman <jgh>
Status: Closed FIXED    
Severity: Affects Many People CC: jgh, marcandre.lureau, olevole
Priority: --- Flags: bugzilla: maintainer-feedback? (jgh)
Version: Latest   
Hardware: Any   
OS: Any   
Bug Depends on: 196949    
Bug Blocks:    
Attachments:
Description Flags
Fix none

Description Dmitry Marakasov freebsd_committer freebsd_triage 2014-12-08 14:10:28 UTC
Created attachment 150350 [details]
Fix

files/patch-virtManager_console.py is broken, see attachment.
Comment 1 Bugzilla Automation freebsd_committer freebsd_triage 2014-12-08 14:10:28 UTC
Auto-assigned to maintainer jgh@FreeBSD.org
Comment 2 Oleg Ginzburg 2014-12-08 14:28:47 UTC
It seems that this part of the code is nonoperating on the FreeBSD platform, since there is no spice-gtk ( http://www.spice-space.org/download.html ) port.

Also i've found some patches https://www.redhat.com/archives/virt-tools-list/2014-November/msg00019.html for more correct processing spice-gtk availability
Comment 3 Marc-André Lureau 2014-12-08 16:13:30 UTC
(In reply to olevole from comment #2)
> It seems that this part of the code is nonoperating on the FreeBSD platform,
> since there is no spice-gtk ( http://www.spice-space.org/download.html )
> port.

Would you mind trying to build spice-gtk on freebsd before? I would be glad to know the problems and help. thanks
Comment 4 Oleg Ginzburg 2014-12-08 16:58:11 UTC
Yes, i've created and install temporary (not ready for the ports tree yet) port:

https://github.com/olevole/fbsd-ports/tree/master/x11/spice-gtk

and passed this place in virt-manager.

However functional has not yet been checked because got another error during "Begin install" stage:

"Control groups not supported on this platform: Device not configured"

Still unclear how to turn cgroups off.
Comment 5 Jason Helfman freebsd_committer freebsd_triage 2014-12-08 17:03:10 UTC
virt-tools-list@redhat.com may have some insight into this.

And thank you!
Comment 6 Jason Helfman freebsd_committer freebsd_triage 2015-01-30 08:02:52 UTC
Please try the port listed in the dependent bug, and let me know if this fixes the issue you are seeing.
Comment 7 Jason Helfman freebsd_committer freebsd_triage 2015-02-04 22:36:09 UTC
I've attached a new shar of spice-gtk port to the #196949
Can you please confirm if this works or not?
Thanks!
Comment 8 Oleg Ginzburg 2015-02-05 09:05:18 UTC
(In reply to jgh from comment #7)

I've test new version of the patch on FreeBSD11/amd64 and it works as expected.
Comment 9 Jason Helfman freebsd_committer freebsd_triage 2015-02-05 17:54:34 UTC
I've updated the shar in the bug 196949 to include the python bindings, which are required for this pr.
Comment 10 commit-hook freebsd_committer freebsd_triage 2015-02-09 16:24:49 UTC
A commit references this bug:

Author: jgh
Date: Mon Feb  9 16:23:50 UTC 2015
New revision: 378740
URL: https://svnweb.freebsd.org/changeset/ports/378740

Log:
  - py-spice-gtk has been added as dependency
  - bump portrevision

  PR:		195809
  Reported by:	amdmi3@

Changes:
  head/deskutils/virt-manager/Makefile
  head/deskutils/virt-manager/files/patch-virtManager_console.py