Bug 196949 - new port x11/spice-gtk: Gtk client and libraries for SPICE remote desktop servers
Summary: new port x11/spice-gtk: Gtk client and libraries for SPICE remote desktop ser...
Status: Closed FIXED
Alias: None
Product: Ports & Packages
Classification: Unclassified
Component: Individual Port(s) (show other bugs)
Version: Latest
Hardware: Any Any
: --- Affects Only Me
Assignee: Jason Helfman
URL:
Keywords:
Depends on:
Blocks: 195809
  Show dependency treegraph
 
Reported: 2015-01-20 21:35 UTC by Oleg Ginzburg
Modified: 2015-02-09 16:28 UTC (History)
2 users (show)

See Also:
jgh: maintainer-feedback+


Attachments
new port x11/spice-gtk: Gtk client and libraries for SPICE remote desktop servers (6.77 KB, application/x-shar)
2015-01-20 21:35 UTC, Oleg Ginzburg
no flags Details
new port deskutils/spice-gtk: Gtk client and libraries for SPICE remote desktop servers (6.82 KB, patch)
2015-01-20 21:54 UTC, Oleg Ginzburg
no flags Details | Diff
reworked port to use options framework (6.15 KB, text/plain)
2015-02-04 18:58 UTC, Jason Helfman
no flags Details
added python support (6.40 KB, text/plain)
2015-02-05 17:40 UTC, Jason Helfman
no flags Details
made python a slave port (6.97 KB, text/plain)
2015-02-08 01:00 UTC, Jason Helfman
no flags Details
updated shar (6.94 KB, text/plain)
2015-02-08 02:11 UTC, Jason Helfman
no flags Details

Note You need to log in before you can comment on or make changes to this bug.
Description Oleg Ginzburg 2015-01-20 21:35:37 UTC
Created attachment 151928 [details]
new port x11/spice-gtk: Gtk client and libraries for SPICE remote desktop servers

new port: Gtk client and libraries for SPICE remote desktop servers
Comment 1 Oleg Ginzburg 2015-01-20 21:54:32 UTC
Created attachment 151932 [details]
new port deskutils/spice-gtk: Gtk client and libraries for SPICE remote desktop servers

Change category from x11 to deskutils
Fix for SASL client dependency
Comment 2 Jason Helfman freebsd_committer freebsd_triage 2015-02-04 18:58:09 UTC
Created attachment 152561 [details]
reworked port to use options framework
Comment 3 Jason Helfman freebsd_committer freebsd_triage 2015-02-04 18:58:52 UTC
Please test out the attached shell archive, and let me know how it works.

Thanks!
Jason
Comment 4 Oleg Ginzburg 2015-02-05 09:06:07 UTC
(In reply to jgh from comment #3)

I've test new version of the patch on FreeBSD11/amd64 and it works as expected.
Comment 5 Jason Helfman freebsd_committer freebsd_triage 2015-02-05 17:40:10 UTC
Created attachment 152596 [details]
added python support

The bug that this addresses needs the python libraries as a default, so I've added this to the port. Please review.
Thanks!
Comment 6 Jason Helfman freebsd_committer freebsd_triage 2015-02-08 01:00:28 UTC
Created attachment 152695 [details]
made python a slave port

virt-manager needs python support, so needed to make a slave explicitly enable it.
Comment 7 Jason Helfman freebsd_committer freebsd_triage 2015-02-08 02:11:22 UTC
Created attachment 152698 [details]
updated shar

simplified for maintenance purposes
Comment 8 Oleg Ginzburg 2015-02-09 08:51:01 UTC
When WITHOUT_DOCS=yes, still installed /usr/local/share/doc/spice-gtk stuff. In my original patch I specifically did this option because needs for invested more time for this and I was planning to do it a little later. Functionally, the latest version is also working, I agree with these changes.
Comment 9 Jason Helfman freebsd_committer freebsd_triage 2015-02-09 16:10:57 UTC
Confirmed. I will add back the static listing in pkg-plist. I've found it best to report an issue like this to upstream maintainers.

Thank you!

-jgh
Comment 10 commit-hook freebsd_committer freebsd_triage 2015-02-09 16:22:48 UTC
A commit references this bug:

Author: jgh
Date: Mon Feb  9 16:22:01 UTC 2015
New revision: 378739
URL: https://svnweb.freebsd.org/changeset/ports/378739

Log:
  Add new ports: spice-gtk and py-spice-gtk

  spice-gtk is a GTK+2 and GTK+3 SPICE widget. It features glib-based objects
  for SPICE protocol parsing and a gtk widget for embedding the SPICE display
  into other applications such as virt-manager.
  Python bindings are available too.

  WWW: http://www.spice-space.org/

  PR:		196949 (based on)
  Submitted by:	olevole@olevole.ru

Changes:
  head/deskutils/py-spice-gtk/
  head/deskutils/py-spice-gtk/Makefile
  head/deskutils/spice-gtk/
  head/deskutils/spice-gtk/Makefile
  head/deskutils/spice-gtk/distinfo
  head/deskutils/spice-gtk/pkg-descr
  head/deskutils/spice-gtk/pkg-plist
Comment 11 Jason Helfman freebsd_committer freebsd_triage 2015-02-09 16:24:33 UTC
Committed, thanks!
Comment 12 commit-hook freebsd_committer freebsd_triage 2015-02-09 16:28:51 UTC
A commit references this bug:

Author: jgh
Date: Mon Feb  9 16:28:11 UTC 2015
New revision: 378741
URL: https://svnweb.freebsd.org/changeset/ports/378741

Log:
  - connect spice-gtk and py-spice-gtk to build

  PR:		196949

Changes:
  head/deskutils/Makefile