Bug 196264

Summary: [iwn] [patch]: few minor fixes
Product: Base System Reporter: Andriy Voskoboinyk <avos>
Component: wirelessAssignee: freebsd-wireless (Nobody) <wireless>
Status: Closed FIXED    
Severity: Affects Only Me CC: adrian
Priority: ---    
Version: CURRENT   
Hardware: Any   
OS: Any   
Attachments:
Description Flags
Remove check for c->ic_flags & IEEE80211_CHAN_PASSIVE
none
Few minor fixes
none
Patch-v2.diff
none
Patch-v2.diff
none
Patch-v3.diff (untested) none

Description Andriy Voskoboinyk freebsd_committer freebsd_triage 2014-12-25 11:43:12 UTC 
Created attachment 150952 [details]
Remove check for c->ic_flags & IEEE80211_CHAN_PASSIVE
Comment 1 Andriy Voskoboinyk freebsd_committer freebsd_triage 2015-03-06 11:35:26 UTC 
Created attachment 153892 [details]
Few minor fixes

- Add missing IWN_UNLOCK(sc).
- Remove redundant initialization in iwn_ioctl().
Comment 2 Andriy Voskoboinyk freebsd_committer freebsd_triage 2015-03-08 09:46:20 UTC 
Created attachment 153995 [details]
Patch-v2.diff

- Set maxfrags to IWN_MAX_SCATTER - 1 (first segment is used by the TX command)
- Remove redundant "not" from error string.
Comment 3 Andriy Voskoboinyk freebsd_committer freebsd_triage 2015-03-08 09:49:30 UTC 
Created attachment 153996 [details]
Patch-v2.diff

Mark previous patches as obsolete.
Comment 4 Andriy Voskoboinyk freebsd_committer freebsd_triage 2015-05-12 20:45:48 UTC 
Created attachment 156730 [details]
Patch-v3.diff (untested)

- Pass control frames to host.
- Do not set TX timer on error.
- Free node references for unsent frames on device stop.
Comment 5 Adrian Chadd freebsd_committer freebsd_triage 2015-05-13 01:16:33 UTC 
Hi,

Do you not have anything with iwn(4) hardware in it?
Comment 6 Andriy Voskoboinyk freebsd_committer freebsd_triage 2015-05-13 13:58:03 UTC 
(In reply to Adrian Chadd from comment #5)
No, I don't have such devices.
Comment 7 Adrian Chadd freebsd_committer freebsd_triage 2015-05-15 02:29:23 UTC 
Would you like a thinkpad with one in it?
Comment 8 commit-hook freebsd_committer freebsd_triage 2015-05-16 05:59:30 UTC 
A commit references this bug:

Author: adrian
Date: Sat May 16 05:59:26 UTC 2015
New revision: 282999
URL: https://svnweb.freebsd.org/changeset/base/282999

Log:
  Various iwn(4) fixes.

  * simplify channel logic for determining RF gain setting in scan setup
  * don't set TX timer on error
  * free node references for unsent frames on device stop
  * set maxfrags to IWN_MAX_SCATTER-1 (first segment is used by TX command)
  * add missing IWN_UNLOCK() from interrupt path when the hardware
    disappears.
  * pass control frames to host
  * nitems() instead of local macro

  Tested:

  * Intel 5100, STA mode

  PR:		kern/196264
  Submitted by:	Andriy Voskoboinyk <s3erios@gmail.com>

Changes:
  head/sys/dev/iwn/if_iwn.c