Bug 196986

Summary: misc/libeatmydata chokes on CC=/nxb-bin/usr/bin/cc
Product: Ports & Packages Reporter: Sean Bruno <sbruno>
Component: Individual Port(s)Assignee: Sean Bruno <sbruno>
Status: Closed FIXED    
Severity: Affects Only Me CC: nagy.attila
Priority: --- Keywords: easy, patch, patch-ready
Version: LatestFlags: bugzilla: maintainer-feedback? (nagy.attila)
Hardware: Any   
OS: Any   
Attachments:
Description Flags
Support full path to cc and make for external toolchains koobs: maintainer-approval? (nagy.attila)

Description Sean Bruno freebsd_committer freebsd_triage 2015-01-22 01:55:00 UTC
I don't think the sed syntax is quite right in this port post-patch to handle the case where CC is an absolute path to a compiler.  This breaks cross compilation for this port.

http://chips.ysv.freebsd.org/data/11armv6-11armv6/2015-01-19_15h28m19s/logs/errors/libeatmydata-9.log
Comment 1 Bugzilla Automation freebsd_committer freebsd_triage 2015-01-22 01:55:00 UTC
Maintainer CC'd
Comment 2 Sean Bruno freebsd_committer freebsd_triage 2015-02-14 18:14:01 UTC
Created attachment 152979 [details]
Support full path to cc and make for external toolchains
Comment 3 Sean Bruno freebsd_committer freebsd_triage 2015-02-14 18:14:45 UTC
http://tasty.ysv.freebsd.org/data/11armv6-default/2015-02-14_18h10m30s/logs/libeatmydata-9.log

Build log from patch where external toolchain is used (qemu powered poudriere).

This fixes portmgr's ability to build for armv6/mips/mips64
Comment 4 Kubilay Kocak freebsd_committer freebsd_triage 2015-02-16 02:55:04 UTC
Submitter is committer
Comment 5 commit-hook freebsd_committer freebsd_triage 2015-02-21 17:50:51 UTC
A commit references this bug:

Author: sbruno
Date: Sat Feb 21 17:50:39 UTC 2015
New revision: 379539
URL: https://svnweb.freebsd.org/changeset/ports/379539

Log:
  Allow the CC expansion to deal with a full path to a compiler.  This
  fixes building with an external toolchain where CC=/nxb-bin/usr/bin/cc
  when used via poudriere + qemu-bsd-user.

  PR:		196986
  Approved by:	maintainer timeout (2 weeks)

Changes:
  head/misc/libeatmydata/Makefile