Bug 196986 - misc/libeatmydata chokes on CC=/nxb-bin/usr/bin/cc
Summary: misc/libeatmydata chokes on CC=/nxb-bin/usr/bin/cc
Status: Closed FIXED
Alias: None
Product: Ports & Packages
Classification: Unclassified
Component: Individual Port(s) (show other bugs)
Version: Latest
Hardware: Any Any
: --- Affects Only Me
Assignee: Sean Bruno
URL:
Keywords: easy, patch, patch-ready
Depends on:
Blocks:
 
Reported: 2015-01-22 01:55 UTC by Sean Bruno
Modified: 2015-02-21 17:51 UTC (History)
1 user (show)

See Also:
bugzilla: maintainer-feedback? (nagy.attila)

Attachments
Support full path to cc and make for external toolchains (359 bytes, patch)
2015-02-14 18:14 UTC, Sean Bruno 		koobs: maintainer-approval? (nagy.attila)
 Details | Diff
View All Add an attachment (proposed patch, testcase, etc.)

Note You need to log in before you can comment on or make changes to this bug.
Description Sean Bruno freebsd_committer freebsd_triage 2015-01-22 01:55:00 UTC 
I don't think the sed syntax is quite right in this port post-patch to handle the case where CC is an absolute path to a compiler.  This breaks cross compilation for this port.

http://chips.ysv.freebsd.org/data/11armv6-11armv6/2015-01-19_15h28m19s/logs/errors/libeatmydata-9.log
Comment 1 Bugzilla Automation freebsd_committer freebsd_triage 2015-01-22 01:55:00 UTC 
Maintainer CC'd
Comment 2 Sean Bruno freebsd_committer freebsd_triage 2015-02-14 18:14:01 UTC 
Created attachment 152979 [details]
Support full path to cc and make for external toolchains
Comment 3 Sean Bruno freebsd_committer freebsd_triage 2015-02-14 18:14:45 UTC 
http://tasty.ysv.freebsd.org/data/11armv6-default/2015-02-14_18h10m30s/logs/libeatmydata-9.log

Build log from patch where external toolchain is used (qemu powered poudriere).

This fixes portmgr's ability to build for armv6/mips/mips64
Comment 4 Kubilay Kocak freebsd_committer freebsd_triage 2015-02-16 02:55:04 UTC 
Submitter is committer
Comment 5 commit-hook freebsd_committer freebsd_triage 2015-02-21 17:50:51 UTC 
A commit references this bug:

Author: sbruno
Date: Sat Feb 21 17:50:39 UTC 2015
New revision: 379539
URL: https://svnweb.freebsd.org/changeset/ports/379539

Log:
  Allow the CC expansion to deal with a full path to a compiler.  This
  fixes building with an external toolchain where CC=/nxb-bin/usr/bin/cc
  when used via poudriere + qemu-bsd-user.

  PR:		196986
  Approved by:	maintainer timeout (2 weeks)

Changes:
  head/misc/libeatmydata/Makefile