Bug 197302
| Summary: | [NEW PORT] devel/hs-ShellCheck - a shell script static analyzer | ||||||
|---|---|---|---|---|---|---|---|
| Product: | Ports & Packages | Reporter: | luca.pizzamiglio | ||||
| Component: | Individual Port(s) | Assignee: | freebsd-haskell (Nobody) <haskell> | ||||
| Status: | Closed FIXED | ||||||
| Severity: | Affects Only Me | CC: | pgj | ||||
| Priority: | --- | ||||||
| Version: | Latest | ||||||
| Hardware: | Any | ||||||
| OS: | Any | ||||||
| Attachments: |
|
||||||
Take, on behalf of haskell@. I have reviewed the submitted port and I have reworked some parts of it. You can find the resulting import to the development overlay at GitHub [1]. Highlights of my changes: - since the package is present on HackageDB, it is probably a better idea to grab the sources from there and use that for the port (that is how the other hs- ports are also done) - you do not have add the "cabal-install" package as a dependency -- that is just a frontend to the Cabal library which is shipped with GHC. So the package will also build without cabal-install installed at all. - the "parsec" package was missing from the list of dependencies. - it is worth adding the actual long description of the Cabal package to pkg-descr, so it gives the user more information about the contents. I will commit the fixed version shortly. [1] https://github.com/freebsd-haskell/ports/commit/1d7d51b5610aa866f152ddd06d2a15ee9e638fc3 thanks for the review. I agree all changes. best regards, pizzamig A commit references this bug: Author: pgj Date: Sun Feb 15 21:45:54 UTC 2015 New revision: 379051 URL: https://svnweb.freebsd.org/changeset/ports/379051 Log: Add new port: devel/hs-ShellCheck The goals of ShellCheck are: * To point out and clarify typical beginner's syntax issues, that causes a shell to give cryptic error messages. * To point out and clarify typical intermediate level semantic problems, that causes a shell to behave strangely and counter-intuitively. * To point out subtle caveats, corner cases and pitfalls, that may cause an advanced user's otherwise working script to fail under future circumstances. WWW: http://www.shellcheck.net/ PR: 197302 Submitted by: luca.pizzamiglio@gmail.com Obtained from: FreeBSD Haskell Changes: head/devel/hs-ShellCheck/ head/devel/hs-ShellCheck/Makefile head/devel/hs-ShellCheck/distinfo head/devel/hs-ShellCheck/files/ head/devel/hs-ShellCheck/files/patch-ShellCheck.cabal head/devel/hs-ShellCheck/pkg-descr head/lang/ghc/bsd.hackage.mk The ports has been committed to the tree with some modifications. Thank you for your submission! |
Created attachment 152531 [details] The shar file, to create the new port This is a shell script static analyzer. It supports sh, bash, and so on. It's written in Haskell.