Bug 197483
| Summary: | [arm] www/webkit-qt5 needs patch for FreeBSD CacheFlush Support | ||||||||
|---|---|---|---|---|---|---|---|---|---|
| Product: | Ports & Packages | Reporter: | Sean Bruno <sbruno> | ||||||
| Component: | Individual Port(s) | Assignee: | Sean Bruno <sbruno> | ||||||
| Status: | Closed FIXED | ||||||||
| Severity: | Affects Some People | CC: | freebsd-arm, kde, mikael | ||||||
| Priority: | --- | Flags: | bugzilla:
maintainer-feedback?
(kde) |
||||||
| Version: | Latest | ||||||||
| Hardware: | arm | ||||||||
| OS: | Any | ||||||||
| Attachments: |
|
||||||||
|
Description
Sean Bruno
2015-02-09 15:47:54 UTC
Auto-assigned to maintainer kde@FreeBSD.org Created attachment 152815 [details] fix build on armv6 The attached patch adds the CacheFlush instructions on ARM. build log (not a poudriere one): http://mikael.urankar.free.fr/FreeBSD/arm/build_logs/qt5-webkit-5.3.2_2.log Test build running. It'll be a bit. http://tasty.ysv.freebsd.org/build.html?mastername=11mips64-default&build=2015-02-09_19h15m14s No objections from kde@ other than you should use spaces instead of tabs in your patch. Also, are you going to submit this upstream? (In reply to Raphael Kubo da Costa from comment #4) ok, we'll fix the tabs/spaces thing. We were hoping that kde@ could upstream this and have not posted it anywhere except to this bug report. While it's certainly possible for me to send it upstream, for example, I believe it makes more sense for the people who actually wrote the code to do that: I, for one, have no idea what the code does, what it is supposed to implement and argue for its inclusion. (In reply to Raphael Kubo da Costa from comment #6) Sure. I understand. Where and how do I report this? e.g. a bugzilla or tracker instance? The contribution guidelines are described here: http://qt-project.org/wiki/Qt-Contribution-Guidelines The TL;DR version is that you're supposed to: 1) Accept Qt's contribution agreement (once) 2) Send your patch through Gerrit targeting the current stable branch (5.4 at the moment) since it's a bug fix. 3) CC one or more people to review your change (you can also CC me in Gerrit). Please let me know if you have any problems or need more information. (In reply to Raphael Kubo da Costa from comment #8) Fired off a jira issue/bug thing: https://bugreports.qt.io/browse/QTBUG-44525 Qt only accepts patches submitted via Gerrit, since you also have to accept its contributor agreement. Can you send your patch through Gerrit and mention the bug report you opened ("Task-number: QTBUG-XXX")?
Created attachment 153286 [details]
Functionally the same patch, but change tabs to spaces.
A commit references this bug: Author: sbruno Date: Sat Feb 21 19:06:12 UTC 2015 New revision: 379541 URL: https://svnweb.freebsd.org/changeset/ports/379541 Log: Add support for armv6 by adding __clear_cache support to ASM in the javascript assembler. This mirrors similar patches to other webkit ports. PR: 197483 Submitted by: mikael.urankar@gmail.com Reviewed by: rakuco@FreeBSD.org (for kde@) Changes: head/www/webkit-qt5/files/patch-Source_JavaScriptCore_assembler_ARMAssembler.h A commit references this bug: Author: rakuco Date: Sat Feb 21 20:16:22 UTC 2015 New revision: 379547 URL: https://svnweb.freebsd.org/changeset/ports/379547 Log: Fix `make patch' after r379541. The new patch just didn't apply, and apparently nobody tested it before committing... PR: 197483 Changes: head/www/webkit-qt5/files/patch-Source_JavaScriptCore_assembler_ARMAssembler.h |