Summary: | Bugzilla diff viewer shows leftover junk for svn property changes | ||||||
---|---|---|---|---|---|---|---|
Product: | Services | Reporter: | Dimitry Andric <dim> | ||||
Component: | Bug Tracker | Assignee: | Marcus von Appen <mva> | ||||
Status: | Closed FIXED | ||||||
Severity: | Affects Only Me | CC: | toni.viemero | ||||
Priority: | --- | ||||||
Version: | unspecified | ||||||
Hardware: | Any | ||||||
OS: | Any | ||||||
Attachments: |
|
Description
Dimitry Andric
2015-02-14 00:53:33 UTC
The problem seems to be within p5-PatchReader, which is used to extract the information from a diff. It is unable to deal with SVN diffs properly at the moment. We will look into this. Created attachment 153180 [details]
p5-PatchReader Update
The following patch should fix the problem. I could not notice any side effects on other patches, so I assume the patch to work correctly for most (if not all) patches.
Toni: can you review the patch and tell me, if it is okay to commit it? Looks good. A commit references this bug: Author: mva Date: Sat Feb 21 09:33:11 UTC 2015 New revision: 379493 URL: https://svnweb.freebsd.org/changeset/ports/379493 Log: - Ignore SVN property changes in PatchReader::Raw. They were mistaken for line changes of the original patch. - This fixes Bugzilla's patch viewer not to show SVN property changes as line additions or removals of a file. PR: 197607 Reported by: dim@ Approved by: toni.viemero@iki.fi (maintainer) Changes: head/devel/p5-PatchReader/Makefile head/devel/p5-PatchReader/files/patch-lib__PatchReader__Raw.pm The PatchReader module has been updated and the property changes should not be shown anymore. |