| Summary: | [MAINTAINER] games/wxlauncher: Update Git commit for 0.9.5 release version | ||||||||||||||||
|---|---|---|---|---|---|---|---|---|---|---|---|---|---|---|---|---|---|
| Product: | Ports & Packages | Reporter: | lightside <lightside> | ||||||||||||||
| Component: | Individual Port(s) | Assignee: | freebsd-ports-bugs (Nobody) <ports-bugs> | ||||||||||||||
| Status: | Closed Not Accepted | ||||||||||||||||
| Severity: | Affects Only Me | ||||||||||||||||
| Priority: | --- | ||||||||||||||||
| Version: | Latest | ||||||||||||||||
| Hardware: | Any | ||||||||||||||||
| OS: | Any | ||||||||||||||||
| Attachments: |
|
||||||||||||||||
|
Description
lightside
2015-03-20 10:45:05 UTC
Created attachment 154564 [details]
The poudriere testport log (FreeBSD 10 amd64)
Created attachment 154566 [details]
Proposed patch (since 379636 revision)
Looks like, there is a need to use DISTVERSIONSUFFIX=-${GH_TAGNAME} for this case, because of different distfile for the same PORTVERSION.
Created attachment 154567 [details]
The poudriere testport log (FreeBSD 10 amd64)
Comment on attachment 154566 [details] Proposed patch (since 379636 revision) (In reply to comment #3) > Looks like, there is a need to use DISTVERSIONSUFFIX=-${GH_TAGNAME} for this case. No, it's not needed, because of "_GH0" postfix already. Created attachment 154613 [details] Proposed patch (since 379636 revision) Let's use GitHub API: https://developer.github.com/v3/repos/contents/#get-archive-link Created attachment 154830 [details]
Proposed patch (since 379636 revision)
I think, there is a (general) misunderstanding about GitHub API (front-end) usage. But also there is a possible reviewer's abuse of conversion from (correct) MASTER_SITES to USE_GITHUB. Therefore, return to use USE_GITHUB with correct DISTNAME (where the current "_GH0" part is responsibility of other people; therefore, if it changed outside of the port, then recreate the distinfo file with "make makesum" command).
Superseded by bug 199429. |