Bug 199220
| Summary: | [PATCH] audio/quimup: Update to version 1.4.0 | ||||||
|---|---|---|---|---|---|---|---|
| Product: | Ports & Packages | Reporter: | tkato432 | ||||
| Component: | Individual Port(s) | Assignee: | John Marino <marino> | ||||
| Status: | Closed FIXED | ||||||
| Severity: | Affects Only Me | CC: | danfe, marino | ||||
| Priority: | --- | Keywords: | patch | ||||
| Version: | Latest | ||||||
| Hardware: | Any | ||||||
| OS: | Any | ||||||
| Attachments: |
|
||||||
Your PR does not explain the switch from Qt4 to Qt5 at all. Note that Qt4 is still being primarily used for vast majority of ports. If needed, another quimup-qt5 port should be created instead (or quimup-qt4, if Qt5-version gains sufficient reasons to become default). It appears that upstream author intentionally discontinued Qt4 support from the latest version. Meanwhile, in general, keeping different versions of the same applications featuring different toolkits as different ports should be avoided unless upstream author claims that the latest version hasn't been stable enough or each ports are necessary for other ports as dependency. In this case, it seem to me that it would be unnecessary to preserve older version in ports tree due to retirement of Qt4 support. A commit references this bug: Author: marino Date: Sat Oct 10 12:15:58 UTC 2015 New revision: 398991 URL: https://svnweb.freebsd.org/changeset/ports/398991 Log: audio/quimup: Upgrade version 1.3.2 => 1.4.0 I tweaked provided patch to revert some unnecessary changes. Technically the change of ${PORTNAME} to quimup is unnecessary but I fully support the reversal of PORTNAME abuse. PR: 199220 Submitted by: ports fury Changes: head/audio/quimup/Makefile head/audio/quimup/distinfo thanks |
Created attachment 155258 [details] audio_quimup.diff