Bug 199327

Summary:	Missing $ for DIST_SUBDIR in Porter's Handbook
Product:	Documentation	Reporter:	Andrew <andrew_terekhov>
Component:	Books & Articles	Assignee:	Mathieu Arnold <mat>
Status:	Closed FIXED
Severity:	Affects Some People	CC:	doc
Priority:	---
Version:	Latest
Hardware:	Any
OS:	Any

Description Andrew 2015-04-09 19:00:00 UTC

Current:

 This will change DISTDIR from the default /usr/ports/distfiles to /usr/ports/distfiles/DIST_SUBDIR, and in effect puts everything that is required for the port into that subdirectory.


Should be (note $ in front of DIST_SUBDIR):

 This will change DISTDIR from the default /usr/ports/distfiles to /usr/ports/distfiles/$DIST_SUBDIR, and in effect puts everything that is required for the port into that subdirectory.

Comment 1 Mathieu Arnold freebsd_committer

2015-04-27 14:41:57 UTC

It was supposed to be pseudo-code because otherwise it's distfiles/${DIST_SUBDIR} (because $DIST_SUBDIR is, in fact ${D}IST_SUBDIR) but maybe it's wrong and we should not use pseudo-code.

Comment 2 commit-hook freebsd_committer

2015-05-05 07:32:38 UTC

A commit references this bug:

Author: mat
Date: Tue May  5 07:31:39 UTC 2015
New revision: 46655
URL: https://svnweb.freebsd.org/changeset/doc/46655

Log:
  Use real Make code and not pseudo-code.

  PR:		199327
  Differential Revision:	https://reviews.freebsd.org/D2437
  Submitted by:	Andrew Terekhov
  Reviewed by:	wblock
  Approved by:	wblock (mentor)
  Sponsored by:	Absolight

Changes:
  head/en_US.ISO8859-1/books/porters-handbook/makefiles/chapter.xml