Bug 199327 - Missing $ for DIST_SUBDIR in Porter's Handbook
Summary: Missing $ for DIST_SUBDIR in Porter's Handbook
Status: Closed FIXED
Alias: None
Product: Documentation
Classification: Unclassified
Component: Books & Articles (show other bugs)
Version: Latest
Hardware: Any Any
: --- Affects Some People
Assignee: Mathieu Arnold
URL:
Keywords:
Depends on:
Blocks:
 
Reported: 2015-04-09 19:00 UTC by Andrew
Modified: 2015-05-05 07:32 UTC (History)
1 user (show)

See Also:

Attachments
Add an attachment (proposed patch, testcase, etc.)

Note You need to log in before you can comment on or make changes to this bug.
Description Andrew 2015-04-09 19:00:00 UTC 
Current:

 This will change DISTDIR from the default /usr/ports/distfiles to /usr/ports/distfiles/DIST_SUBDIR, and in effect puts everything that is required for the port into that subdirectory.


Should be (note $ in front of DIST_SUBDIR):

 This will change DISTDIR from the default /usr/ports/distfiles to /usr/ports/distfiles/$DIST_SUBDIR, and in effect puts everything that is required for the port into that subdirectory.
Comment 1 Mathieu Arnold freebsd_committer freebsd_triage 2015-04-27 14:41:57 UTC 
It was supposed to be pseudo-code because otherwise it's distfiles/${DIST_SUBDIR} (because $DIST_SUBDIR is, in fact ${D}IST_SUBDIR) but maybe it's wrong and we should not use pseudo-code.
Comment 2 commit-hook freebsd_committer freebsd_triage 2015-05-05 07:32:38 UTC 
A commit references this bug:

Author: mat
Date: Tue May  5 07:31:39 UTC 2015
New revision: 46655
URL: https://svnweb.freebsd.org/changeset/doc/46655

Log:
  Use real Make code and not pseudo-code.

  PR:		199327
  Differential Revision:	https://reviews.freebsd.org/D2437
  Submitted by:	Andrew Terekhov
  Reviewed by:	wblock
  Approved by:	wblock (mentor)
  Sponsored by:	Absolight

Changes:
  head/en_US.ISO8859-1/books/porters-handbook/makefiles/chapter.xml