Bug 200807

Summary:	[exp-run] Set some functions on libugidfw(3) as static to silence clang warning.
Product:	Ports & Packages	Reporter:	Marcelo Araujo <araujo>
Component:	Ports Framework	Assignee:	Marcelo Araujo <araujo>
Status:	Closed FIXED
Severity:	Affects Only Me	CC:	araujobsdport, portmgr
Priority:	---	Flags:	araujo: exp-run?
Version:	Latest
Hardware:	Any
OS:	Any

Description Marcelo Araujo freebsd_committer

2015-06-12 04:00:02 UTC

Those functions seemed to be helpers and is safe to set it as static.
However, I would like to double check with an 'exp run' if any external project is using those functions that I will change.

Review: https://reviews.freebsd.org/D2775

Comment 1 Marcelo Araujo freebsd_committer

2015-06-15 14:58:25 UTC

*** Bug 200805 has been marked as a duplicate of this bug. ***

Comment 2 Antoine Brodin freebsd_committer

2015-06-15 19:53:12 UTC

Take

Comment 3 Antoine Brodin freebsd_committer

2015-06-17 18:55:48 UTC

Exp-run results:

http://package18.nyi.freebsd.org/jail.html?mastername=headamd64D2775-default

0 new failure,  and i believe 0 port link against libugidfw.

Comment 4 commit-hook freebsd_committer

2015-06-24 01:49:33 UTC

A commit references this bug:

Author: araujo
Date: Wed Jun 24 01:48:46 UTC 2015
New revision: 284745
URL: https://svnweb.freebsd.org/changeset/base/284745

Log:
  Set some internal helpers as static and initialize few variables to silence
  CLANG WARNINGS.
  BUMP SHLIB_MAJOR version as the ABI potentially changed.

  Also run an 'exp run' to double check if any external project are using
  those functions. Thanks antoine@.

  PR:			200807
  Differential Revision:	D2775
  Reviewed by:		kib, ngie

Changes:
  head/lib/libugidfw/Makefile
  head/lib/libugidfw/ugidfw.c

Comment 5 Marcelo Araujo freebsd_committer

2015-06-24 01:58:25 UTC

Committed, thanks!