Bug 200807 - [exp-run] Set some functions on libugidfw(3) as static to silence clang warning.
Summary: [exp-run] Set some functions on libugidfw(3) as static to silence clang warning.
Status: Closed FIXED
Alias: None
Product: Ports & Packages
Classification: Unclassified
Component: Ports Framework (show other bugs)
Version: Latest
Hardware: Any Any
: --- Affects Only Me
Assignee: Marcelo Araujo
URL:
Keywords:
: 200805 (view as bug list)
Depends on:
Blocks:
 
Reported: 2015-06-12 04:00 UTC by Marcelo Araujo
Modified: 2015-06-24 01:58 UTC (History)
2 users (show)

See Also:
araujo: exp-run?

Attachments
Add an attachment (proposed patch, testcase, etc.)

Note You need to log in before you can comment on or make changes to this bug.
Description Marcelo Araujo freebsd_committer freebsd_triage 2015-06-12 04:00:02 UTC 
Those functions seemed to be helpers and is safe to set it as static.
However, I would like to double check with an 'exp run' if any external project is using those functions that I will change.

Review: https://reviews.freebsd.org/D2775
Comment 1 Marcelo Araujo freebsd_committer freebsd_triage 2015-06-15 14:58:25 UTC 
*** Bug 200805 has been marked as a duplicate of this bug. ***
Comment 2 Antoine Brodin freebsd_committer freebsd_triage 2015-06-15 19:53:12 UTC 
Take
Comment 3 Antoine Brodin freebsd_committer freebsd_triage 2015-06-17 18:55:48 UTC 
Exp-run results:

http://package18.nyi.freebsd.org/jail.html?mastername=headamd64D2775-default

0 new failure,  and i believe 0 port link against libugidfw.
Comment 4 commit-hook freebsd_committer freebsd_triage 2015-06-24 01:49:33 UTC 
A commit references this bug:

Author: araujo
Date: Wed Jun 24 01:48:46 UTC 2015
New revision: 284745
URL: https://svnweb.freebsd.org/changeset/base/284745

Log:
  Set some internal helpers as static and initialize few variables to silence
  CLANG WARNINGS.
  BUMP SHLIB_MAJOR version as the ABI potentially changed.

  Also run an 'exp run' to double check if any external project are using
  those functions. Thanks antoine@.

  PR:			200807
  Differential Revision:	D2775
  Reviewed by:		kib, ngie

Changes:
  head/lib/libugidfw/Makefile
  head/lib/libugidfw/ugidfw.c
Comment 5 Marcelo Araujo freebsd_committer freebsd_triage 2015-06-24 01:58:25 UTC 
Committed, thanks!