Bug 201331
| Summary: | [patch] security/arm: arm script relies on python binary the dependency does not provide | ||||||
|---|---|---|---|---|---|---|---|
| Product: | Ports & Packages | Reporter: | Fabian Keil <fk> | ||||
| Component: | Individual Port(s) | Assignee: | Carlo Strub <cs> | ||||
| Status: | Closed Overcome By Events | ||||||
| Severity: | Affects Only Me | CC: | cs, koobs, python | ||||
| Priority: | --- | Keywords: | needs-qa, patch | ||||
| Version: | Latest | Flags: | koobs:
maintainer-feedback?
(cs) |
||||
| Hardware: | Any | ||||||
| OS: | Any | ||||||
| Attachments: |
|
||||||
Fabian, are you sure you don't want to use PYTHON_CMD for this? Additionally, could shebangfix help here? Also, individual port issue reports go in the "Invidual Port" category, Ports Framework is for /usr/ports/Mk/* files as the description of the component describes. I rarely touch python ports and thus have no strong opinions about which variable to use. In my opinion this is a maintainer decision anyway.
shebangfix does not help here because ${WRKSRC}/arm is a shell script and the shebang is fine.
I'm sorry about the misfiling, it wasn't intentional.
I actually prefer to add the meta-port to the dependencies. What do you think? If you prefer adding the meta-port dependency, that's fine with me, too. arm replaced by security/nyx |
Created attachment 158336 [details] security/arm: Adjust arm start script to use an existing python binary The attached patch adjusts the arm start script to use the python binary from the dependency to make sure it works if the python meta-port isn't installed. And alternative would be adding the meta-port to the dependencies. Additionally the patch removes two stray spaces Emacs complaints about but that don't seem to break anything.