Bug 201331 - [patch] security/arm: arm script relies on python binary the dependency does not provide
Summary: [patch] security/arm: arm script relies on python binary the dependency does ...
Status: Closed Overcome By Events
Alias: None
Product: Ports & Packages
Classification: Unclassified
Component: Individual Port(s) (show other bugs)
Version: Latest
Hardware: Any Any
: --- Affects Only Me
Assignee: Carlo Strub
URL:
Keywords: needs-qa, patch
Depends on:
Blocks:
 
Reported: 2015-07-04 15:04 UTC by Fabian Keil
Modified: 2017-11-07 21:57 UTC (History)
3 users (show)

See Also:
koobs: maintainer-feedback? (cs)


Attachments
security/arm: Adjust arm start script to use an existing python binary (1.33 KB, patch)
2015-07-04 15:04 UTC, Fabian Keil
no flags Details | Diff

Note You need to log in before you can comment on or make changes to this bug.
Description Fabian Keil 2015-07-04 15:04:54 UTC
Created attachment 158336 [details]
security/arm: Adjust arm start script to use an existing python binary

The attached patch adjusts the arm start script to use
the python binary from the dependency to make sure it
works if the python meta-port isn't installed.

And alternative would be adding the meta-port to the
dependencies.

Additionally the patch removes two stray spaces Emacs
complaints about but that don't seem to break anything.
Comment 1 Kubilay Kocak freebsd_committer freebsd_triage 2015-07-05 01:36:45 UTC
Fabian, are you sure you don't want to use PYTHON_CMD for this?

Additionally, could shebangfix help here?

Also, individual port issue reports go in the "Invidual Port" category, Ports Framework is for /usr/ports/Mk/* files as the description of the component describes.
Comment 2 Fabian Keil 2015-07-05 08:29:51 UTC
I rarely touch python ports and thus have no strong opinions about which variable to use. In my opinion this is a maintainer decision anyway.

shebangfix does not help here because ${WRKSRC}/arm is a shell script and the shebang is fine.

I'm sorry about the misfiling, it wasn't intentional.
Comment 3 Carlo Strub freebsd_committer 2015-09-20 20:09:29 UTC
I actually prefer to add the meta-port to the dependencies. What do you think?
Comment 4 Fabian Keil 2015-09-21 15:56:41 UTC
If you prefer adding the meta-port dependency, that's fine with me, too.
Comment 5 Carlo Strub freebsd_committer 2017-11-07 21:57:26 UTC
arm replaced by security/nyx