Bug 201779
| Summary: | PORTS_MODULES does not support make reinstallkernel | ||
|---|---|---|---|
| Product: | Base System | Reporter: | rkoberman |
| Component: | misc | Assignee: | Bryan Drewery <bdrewery> |
| Status: | Closed FIXED | ||
| Severity: | Affects Only Me | CC: | bdrewery, imp, pl |
| Priority: | --- | Flags: | pl:
mfc-stable11?
|
| Version: | 10.1-STABLE | ||
| Hardware: | Any | ||
| OS: | Any | ||
I know this is an old report but I get the impression it got overlooked, because right now I'm experiencing the same thing on RELENG 11.0. I have set PORTS_MODULES=net/bwn-firmware-kmod in order to ensure that the BWN firmware gets rebuild the moment I build my kernel. Because I made some specific changes earlier I decided to keep my backup kernel and re-install the new one.
Well...
===> Ports module net/bwn-firmware-kmod (reinstall)
cd ${PORTSDIR:-/usr/ports}/net/bwn-firmware-kmod; env -u CC -u CXX -u CPP PATH=/usr/obj/usr/src/tmp/legacy/usr/sbin:/usr/obj/usr/src/tmp/legacy/usr/bin:/usr/obj/usr/src/tmp/legacy/bin:/usr/obj/usr/src/tmp/usr/sbin:/usr/obj/usr/src/tmp/usr/bin:/sbin:/bin:/usr/sbin:/usr/bin:/usr/local/bin:/usr/local/sbin SRC_BASE=/usr/src OSVERSION=1100122 WRKDIRPREFIX=/usr/obj/usr/src/sys/FELINER make -B redeinstall deinstall reinstall
make[3]: don't know how to make redeinstall. Stop
make[3]: stopped in /usr/ports/net/bwn-firmware-kmod
*** Error code 2
I think this fully rules out the possibility that it might be the Port which didn't handle a target correctly.
I'll look at this, since I use this support. A commit references this bug: Author: bdrewery Date: Sat Nov 18 20:01:02 UTC 2017 New revision: 325970 URL: https://svnweb.freebsd.org/changeset/base/325970 Log: Fix 'make -n' for {reinstall,distribute}kernel. PR: 201779 Sponsored by: Dell Changes: head/Makefile.inc1 A commit references this bug: Author: bdrewery Date: Sat Nov 18 20:01:06 UTC 2017 New revision: 325971 URL: https://svnweb.freebsd.org/changeset/base/325971 Log: Fix PORTS_MODULES+'make reinstallkernel' trying to run bogus 'make redeinstall'. Also fix 'make installkernel' running 'make deinstall' twice. PR: 201779 MFC after: 2 weeks Sponsored by: Dell Changes: head/sys/conf/kern.post.mk |
If a system defines "PORTS_MODULES in /etc/src.conf, doing a a "make reinstallkernel" fails as bsd.port.mk does not define a target for "redeinstall". ===> Ports module emulators/virtualbox-ose-kmod (reinstall) cd ${PORTSDIR:-/usr/ports}/emulators/virtualbox-ose-kmod; PATH=/usr/obj/usr/src/tmp/legacy/usr/sbin:/usr/obj/usr/src/tmp/legacy/usr/bin:/usr/obj/usr/src/tmp/legacy/usr/games:/usr/obj/usr/src/tmp/legacy/bin:/usr/obj/usr/src/tmp/usr/sbin:/usr/obj/usr/src/tmp/usr/bin:/usr/obj/usr/src/tmp/usr/games:/sbin:/bin:/usr/sbin:/usr/bin:/usr/local/bin:/usr/local/sbin SRC_BASE=/usr/src OSVERSION=1001519 WRKDIRPREFIX=/usr/obj/usr/src/sys/ make -B redeinstall deinstall reinstall make[3]: don't know how to make redeinstall. Stop It looks to me like redeinstall can simply be defined as "reinstall deinstall" It is not super-significant, but it would be nice if it worked.