Bug 201802
| Summary: | [NEW PORT] games/hypatia_engine: Hypatia 2D Game Engine | ||||||||||||||
|---|---|---|---|---|---|---|---|---|---|---|---|---|---|---|---|
| Product: | Ports & Packages | Reporter: | Lillian Lynn Lemmer <lillian.lynn.lemmer> | ||||||||||||
| Component: | Individual Port(s) | Assignee: | Kurt Jaeger <pi> | ||||||||||||
| Status: | Closed FIXED | ||||||||||||||
| Severity: | Affects Only Me | CC: | cjpm, koobs, pi | ||||||||||||
| Priority: | --- | Keywords: | needs-qa, patch | ||||||||||||
| Version: | Latest | ||||||||||||||
| Hardware: | Any | ||||||||||||||
| OS: | Any | ||||||||||||||
| URL: | https://reviews.freebsd.org/D2896 | ||||||||||||||
| Attachments: |
|
||||||||||||||
|
Description
Lillian Lynn Lemmer
2015-07-24 01:25:33 UTC
Hm, oops, seems like my shar file didn't submit because it was blank... just gimme a little bit to fix that. Created attachment 159125 [details]
The shar file for Hypatia 0.2.29
Thanks for your submission Lillian! As per the original work to commit this to the ports tree, the name of the package must match the PyPi name (hypatia_engine). I can see quite a few issues that need to be addressed, so I highly recommend running your port through QA, which will highlight the issues for you, including: * portlint * poudriere You can find more information and instructions here: https://www.freebsd.org/doc/en_US.ISO8859-1/books/porters-handbook/testing.html (In reply to Kubilay Kocak from comment #3) I take charge of provide logs via poudriere, portlint output, etc. Created attachment 159196 [details]
hypatia.shar
% portlint -AC WARN: Consider to set DEVELOPER=yes in /etc/make.conf 0 fatal errors and 1 warning found. Poudriere build logs on 9.3/amd64, 9.3/i386 and 10.1/i386. http://fbsd.es/~cpm/freebsd/poudriere/freebsd:9:x86:64/2015-07-25_02h47m07s/logs/hypatia-0.2.29.log http://fbsd.es/~cpm/freebsd/poudriere/freebsd:9:x86:32/2015-07-24_21h52m18s/logs/hypatia-0.2.29.log http://fbsd.es/~cpm/freebsd/poudriere/freebsd:10:x86:32/2015-07-25_13h56m22s/logs/hypatia-0.2.29.log Kubilay, The distfile is downloaded from a GH repository (no CHEESESHOP site). Rename it to hypatia_engine makes sense. Created attachment 159223 [details]
hypatia.shar
Created attachment 159224 [details]
hypatia.shar
On my testbox 10.1-i386 math/atlas fails to build, so I can't test the port. On 10.1a and 9.3a it builds. (In reply to Kurt Jaeger from comment #11) OK, anything else? We can commit this port... if koobs@ is agree. This tarball is different https://pypi.python.org/packages/source/h/hypatia_engine/hypatia_engine-0.2.29.tar.gz than the sources from the GH repository. So, what source for the engine is correct ? github oder pypi ? And which name is correct for the port ? (In reply to Kurt Jaeger from comment #13) My last comment on the phabricator review covers it, but just to reiterate: - correct name is the one that matches pypi name: hypatia_engine - master_site doesnt really matter. it's available from CHEESESHOP (preferred default) and github Created attachment 159549 [details]
hypatia_engine.shar
- Changed hypatia -> hypatia_engine portname.
Testing @work A commit references this bug: Author: pi Date: Thu Aug 6 05:18:26 UTC 2015 New revision: 393630 URL: https://svnweb.freebsd.org/changeset/ports/393630 Log: New port: games/hypatia_engine Make 2D action adventure games. For programmers and nonprogrammers alike. Create a games like Legend of Zelda: Oracle of Ages and Oracle of Seasons. WWW: http://lillian-lemmer.github.io/hypatia PR: 201802 Submitted by: Lillian Lynn Lemmer <lillian.lynn.lemmer@gmail.com> Changes: head/games/Makefile head/games/hypatia_engine/ head/games/hypatia_engine/Makefile head/games/hypatia_engine/distinfo head/games/hypatia_engine/pkg-descr build-tests on cur 93a 10.1a 10.1i were OK. Committed, thanks! |
