Bug 201978
| Summary: | 286035: make delete-old: OptionalObsoleteFiles.inc" line 1654: Malformed conditional | ||||||
|---|---|---|---|---|---|---|---|
| Product: | Base System | Reporter: | O. Hartmann <ohartmann> | ||||
| Component: | misc | Assignee: | Ed Maste <emaste> | ||||
| Status: | Closed FIXED | ||||||
| Severity: | Affects Many People | CC: | emaste | ||||
| Priority: | --- | ||||||
| Version: | CURRENT | ||||||
| Hardware: | Any | ||||||
| OS: | Any | ||||||
| Attachments: |
|
||||||
A commit references this bug: Author: emaste Date: Wed Jul 29 21:41:16 UTC 2015 New revision: 286044 URL: https://svnweb.freebsd.org/changeset/base/286044 Log: MK_ELFCOPY_AS_OBJCOPY should be a variable PR: 201978 Submitted by: O. Hartmann Differential Revision: https://reviews.freebsd.org/D2887 Changes: head/tools/build/mk/OptionalObsoleteFiles.inc Indeed, sorry about that and thank you for the patch. |
Created attachment 159371 [details] Patch for tools/build/mk/OptionalObsoleteFiles.inc There is an obvious typo in tools/build/mk/OptionalObsoleteFiles.inc, which has been introduced recently with, I believe it is ~ r286035, which makes a delete make-old in /usr/src failing with: make[1]: "/usr/src/tools/build/mk/OptionalObsoleteFiles.inc" line 1654: Malformed conditional (${MK_ELFTOOLCHAIN_TOOLS} == no || (${MK_ELFTOOLCHAIN_TOOLS} != no && MK_ELFCOPY_AS_OBJCOPY != no)) make[1]: Fatal errors encountered -- cannot continue make[1]: stopped in /usr/src *** Error code 1 Stop. make: stopped in /usr/src Attached, you'll find for your convenience a patch - it is obvious that the author forgot to enclose the variable MK_ELFCOPY_AS_OBJCOPY by ${...} marking it as a variable.