Bug 201978 - 286035: make delete-old: OptionalObsoleteFiles.inc" line 1654: Malformed conditional
Summary: 286035: make delete-old: OptionalObsoleteFiles.inc" line 1654: Malformed cond...
Status: Closed FIXED
Alias: None
Product: Base System
Classification: Unclassified
Component: misc (show other bugs)
Version: CURRENT
Hardware: Any Any
: --- Affects Many People
Assignee: Ed Maste
URL:
Keywords:
Depends on:
Blocks:
 
Reported: 2015-07-29 19:59 UTC by O. Hartmann
Modified: 2015-07-29 21:43 UTC (History)
1 user (show)

See Also:

Attachments
Patch for tools/build/mk/OptionalObsoleteFiles.inc (461 bytes, patch)
2015-07-29 19:59 UTC, O. Hartmann 		no flags Details | Diff
View All Add an attachment (proposed patch, testcase, etc.)

Note You need to log in before you can comment on or make changes to this bug.
Description O. Hartmann 2015-07-29 19:59:53 UTC 
Created attachment 159371 [details]
Patch for tools/build/mk/OptionalObsoleteFiles.inc

There is an obvious typo in tools/build/mk/OptionalObsoleteFiles.inc, which has been introduced recently with, I believe it is ~ r286035, which makes a 

delete make-old

in /usr/src failing with:

make[1]: "/usr/src/tools/build/mk/OptionalObsoleteFiles.inc" line 1654: Malformed conditional (${MK_ELFTOOLCHAIN_TOOLS} == no ||  (${MK_ELFTOOLCHAIN_TOOLS} != no && MK_ELFCOPY_AS_OBJCOPY != no))
make[1]: Fatal errors encountered -- cannot continue
make[1]: stopped in /usr/src
*** Error code 1

Stop.
make: stopped in /usr/src


Attached, you'll find for your convenience a patch - it is obvious that the author forgot to enclose the variable MK_ELFCOPY_AS_OBJCOPY by ${...} marking it as a variable.
Comment 1 commit-hook freebsd_committer freebsd_triage 2015-07-29 21:42:15 UTC 
A commit references this bug:

Author: emaste
Date: Wed Jul 29 21:41:16 UTC 2015
New revision: 286044
URL: https://svnweb.freebsd.org/changeset/base/286044

Log:
  MK_ELFCOPY_AS_OBJCOPY should be a variable

  PR:		201978
  Submitted by:	O. Hartmann
  Differential Revision:	https://reviews.freebsd.org/D2887

Changes:
  head/tools/build/mk/OptionalObsoleteFiles.inc
Comment 2 Ed Maste freebsd_committer freebsd_triage 2015-07-29 21:43:35 UTC 
Indeed, sorry about that and thank you for the patch.