Bug 202530

Summary:

Fix lang/v8 build with clang 3.7.0

Product:

Ports & Packages

Reporter:

Dimitry Andric <dim>

Component:

Individual Port(s)

Assignee:

Po-Chuan Hsieh <sunpoet>

Status:

Closed FIXED

Severity:

Affects Some People

Flags:

bugzilla: maintainer-feedback? (sunpoet)

Priority:

---

Version:

Latest

Hardware:

Any

OS:

Any

Bug Depends on:

Bug Blocks:

201377

Attachments:

Description	Flags
Fix various warnings in lang/v8 while building with clang 3.7.0	none

Description Dimitry Andric freebsd_committer

2015-08-20 21:05:01 UTC

Created attachment 160156 [details]
Fix various warnings in lang/v8 while building with clang 3.7.0

During the exp-run in bug 201377, it was found that lang/v8 gives errors with a recent clang 3.7.0 snapshot:

http://package18.nyi.freebsd.org/data/headi386PR201377-default/2015-07-31_12h04m22s/logs/errors/v8-3.18.5_1.log

This log only contains the -Werror warnings about printing non-void pointers with %p, but a newer trunk version of clang also generates a number of warnings about left-shifting negative numbers.

I have fixed both types of warnings in the attached patch.

Comment 1 commit-hook freebsd_committer

2015-09-20 20:18:17 UTC

A commit references this bug:

Author: sunpoet
Date: Sun Sep 20 20:17:30 UTC 2015
New revision: 397412
URL: https://svnweb.freebsd.org/changeset/ports/397412

Log:
  - Fix warnings generated by recent snapshot of Clang 3.7.0, including:
    - Printing non-void pointers with %p.
    - Left-shifting negative numbers.

  PR:		202530
  Submitted by:	dim

Changes:
  head/lang/v8/files/patch-src-checks.h
  head/lang/v8/files/patch-src-deoptimizer.cc
  head/lang/v8/files/patch-src-ia32-code-stubs-ia32.cc
  head/lang/v8/files/patch-src-ia32-disasm-ia32.cc
  head/lang/v8/files/patch-src-ia32-ic-ia32.cc
  head/lang/v8/files/patch-src-liveedit.cc
  head/lang/v8/files/patch-src-objects.h

Comment 2 Po-Chuan Hsieh freebsd_committer

2015-09-20 20:31:47 UTC

Committed. Thanks!