Bug 203737
| Summary: | [patch][new maintainer] www/serendipity: update to 2.02 and become maintainer | ||||||||||||
|---|---|---|---|---|---|---|---|---|---|---|---|---|---|
| Product: | Ports & Packages | Reporter: | Torsten Zühlsdorff <ports> | ||||||||||
| Component: | Individual Port(s) | Assignee: | Dmitry Marakasov <amdmi3> | ||||||||||
| Status: | Closed FIXED | ||||||||||||
| Severity: | Affects Only Me | Keywords: | patch | ||||||||||
| Priority: | --- | ||||||||||||
| Version: | Latest | ||||||||||||
| Hardware: | Any | ||||||||||||
| OS: | Any | ||||||||||||
| Attachments: |
|
||||||||||||
Created attachment 161980 [details]
poudriere log
This port chowns www:www all installed files. This is a security problem, only writable directories should be owned by www. While here, could you please look into it? Documentation should probably mention which files/dirs whould be writable. Created attachment 162031 [details]
patch with update to 2.0.2
Reworked the plist as requested. I only set www/www to the directories the setup requested as mandatory writable.
All files are still owned by www:www. You'll need to remove @owner/@group directives at the start of plist and only wrap selected @dirs in them. Or, which I personally prefer, not use @owner/@group at all and instead use something like: @dir(%%WWWOWN%%,%%WWWGRP%%,) %%WWWDIR%%/some_writable_dir or, if specific permissions are needed: @dir(%%WWWOWN%%,%%WWWGRP%%,775) %%WWWDIR%%/some_writable_dir Created attachment 162044 [details]
patch with update to 2.0.2 - v3
Sorry - i got you wrong.
Updated patch attached :)
Thank you! A commit references this bug: Author: amdmi3 Date: Wed Oct 14 20:39:13 UTC 2015 New revision: 399294 URL: https://svnweb.freebsd.org/changeset/ports/399294 Log: - Update to 2.02 - Fix ownership in plist - Fix sqlite dependency - Remove unneeded lines - Pass maintainership to submitter PR: 203737 Submitted by: ports@toco-domains.de Changes: head/www/serendipity/Makefile head/www/serendipity/distinfo head/www/serendipity/pkg-plist |
Created attachment 161979 [details] patch with update to 2.0.2 Hello, i wrote an update of this software to version 2.0.2. I also: - want to become maintainer of this port - remove unused lines - fix sqlite reference which just works for PHP 5.3 Greetings, Torsten