Bug 203737 - [patch][new maintainer] www/serendipity: update to 2.02 and become maintainer
Summary: [patch][new maintainer] www/serendipity: update to 2.02 and become maintainer
Status: Closed FIXED
Alias: None
Product: Ports & Packages
Classification: Unclassified
Component: Individual Port(s) (show other bugs)
Version: Latest
Hardware: Any Any
: --- Affects Only Me
Assignee: Dmitry Marakasov
URL:
Keywords: patch
Depends on:
Blocks:
 
Reported: 2015-10-13 09:28 UTC by Torsten Zühlsdorff
Modified: 2015-10-14 20:39 UTC (History)
0 users

See Also:

Attachments
patch with update to 2.0.2 (193.46 KB, patch)
2015-10-13 09:28 UTC, Torsten Zühlsdorff 		no flags Details | Diff
poudriere log (36.86 KB, text/x-log)
2015-10-13 09:29 UTC, Torsten Zühlsdorff 		no flags Details
patch with update to 2.0.2 (178.85 KB, patch)
2015-10-14 11:54 UTC, Torsten Zühlsdorff 		no flags Details | Diff
patch with update to 2.0.2 - v3 (178.95 KB, patch)
2015-10-14 16:11 UTC, Torsten Zühlsdorff 		no flags Details | Diff
Show Obsolete (2) View All Add an attachment (proposed patch, testcase, etc.)

Note You need to log in before you can comment on or make changes to this bug.
Description Torsten Zühlsdorff 2015-10-13 09:28:35 UTC 
Created attachment 161979 [details]
patch with update to 2.0.2

Hello,

i wrote an update of this software to version 2.0.2. I also:
- want to become maintainer of this port
- remove unused lines 
- fix sqlite reference which just works for PHP 5.3

Greetings,
Torsten
Comment 1 Torsten Zühlsdorff 2015-10-13 09:29:00 UTC 
Created attachment 161980 [details]
poudriere log
Comment 2 Dmitry Marakasov freebsd_committer freebsd_triage 2015-10-13 21:59:13 UTC 
This port chowns www:www all installed files. This is a security problem, only writable directories should be owned by www. While here, could you please look into it? Documentation should probably mention which files/dirs whould be writable.
Comment 3 Torsten Zühlsdorff 2015-10-14 11:54:52 UTC 
Created attachment 162031 [details]
patch with update to 2.0.2

Reworked the plist as requested. I only set www/www to the directories the setup requested as mandatory writable.
Comment 4 Dmitry Marakasov freebsd_committer freebsd_triage 2015-10-14 16:01:15 UTC 
All files are still owned by www:www. You'll need to remove @owner/@group directives at the start of plist and only wrap selected @dirs in them. Or, which I personally prefer, not use @owner/@group at all and instead use something like:

@dir(%%WWWOWN%%,%%WWWGRP%%,) %%WWWDIR%%/some_writable_dir

or, if specific permissions are needed:

@dir(%%WWWOWN%%,%%WWWGRP%%,775) %%WWWDIR%%/some_writable_dir
Comment 5 Torsten Zühlsdorff 2015-10-14 16:11:29 UTC 
Created attachment 162044 [details]
patch with update to 2.0.2 - v3

Sorry - i got you wrong.

Updated patch attached :)
Comment 6 Dmitry Marakasov freebsd_committer freebsd_triage 2015-10-14 20:39:19 UTC 
Thank you!
Comment 7 commit-hook freebsd_committer freebsd_triage 2015-10-14 20:39:54 UTC 
A commit references this bug:

Author: amdmi3
Date: Wed Oct 14 20:39:13 UTC 2015
New revision: 399294
URL: https://svnweb.freebsd.org/changeset/ports/399294

Log:
  - Update to 2.02
  - Fix ownership in plist
  - Fix sqlite dependency
  - Remove unneeded lines
  - Pass maintainership to submitter

  PR:		203737
  Submitted by:	ports@toco-domains.de

Changes:
  head/www/serendipity/Makefile
  head/www/serendipity/distinfo
  head/www/serendipity/pkg-plist