Bug 204510
| Summary: | Mk/bsd.options.mk: Trigger _OFF helpers for OPTIONS_EXCLUDE_${OPSYS} | ||||||
|---|---|---|---|---|---|---|---|
| Product: | Ports & Packages | Reporter: | Jan Beich <jbeich> | ||||
| Component: | Ports Framework | Assignee: | Mathieu Arnold <mat> | ||||
| Status: | Closed FIXED | ||||||
| Severity: | Affects Only Me | CC: | portmgr, ports-bugs | ||||
| Priority: | --- | Keywords: | patch, patch-ready | ||||
| Version: | Latest | Flags: | koobs:
merge-quarterly?
|
||||
| Hardware: | Any | ||||||
| OS: | Any | ||||||
| Attachments: |
|
||||||
ports r382333 added OPTIONS_EXCLUDE_${OPSYS} support but missed one more place where available options are enumerated. This leads to inconsistency in how option helpers work when used together with OPTIONS_EXCLUDE*. OPTIONS_EXCLUDE_DragonFly has very few consumers most of which use !${PORT_OPTIONS:MFOO} rather than _OFF helpers. So, test with $ make clean all OPSYS=DragonFly -C devel/fb-adb This looks good, please commit. Comment on attachment 163071 [details]
v1
Maintainer (portmgr, antoine) approved.
there are other missing, I'll fix. Well, there were no other problems, but I did things a bit differently in the end. A commit references this bug: Author: mat Date: Fri Nov 13 13:50:35 UTC 2015 New revision: 401514 URL: https://svnweb.freebsd.org/changeset/ports/401514 Log: Refactor the list of all excluded options so that the second place it is needed is not forgotten any more. PR: 204510 With hat: portmgr Sponsored by: Absolight Changes: head/Mk/bsd.options.mk A commit references this bug: Author: mat Date: Fri Nov 13 13:50:45 UTC 2015 New revision: 401515 URL: https://svnweb.freebsd.org/changeset/ports/401515 Log: Remove this hack, now that the framework is fixed. PR: 204510 Submitted by: jbeich Sponsored by: Absolight Changes: head/devel/fb-adb/Makefile |
Created attachment 163071 [details] v1