Bug 204510 - Mk/bsd.options.mk: Trigger _OFF helpers for OPTIONS_EXCLUDE_${OPSYS}
Summary: Mk/bsd.options.mk: Trigger _OFF helpers for OPTIONS_EXCLUDE_${OPSYS}
Status: Closed FIXED
Alias: None
Product: Ports & Packages
Classification: Unclassified
Component: Ports Framework (show other bugs)
Version: Latest
Hardware: Any Any
: --- Affects Only Me
Assignee: Mathieu Arnold
Keywords: patch, patch-ready
Depends on:
Reported: 2015-11-13 00:35 UTC by Jan Beich
Modified: 2015-11-13 13:51 UTC (History)
2 users (show)

See Also:
koobs: merge-quarterly?

v1 (1.15 KB, patch)
2015-11-13 00:35 UTC, Jan Beich
koobs: maintainer-approval+
Details | Diff

Note You need to log in before you can comment on or make changes to this bug.
Description Jan Beich freebsd_committer 2015-11-13 00:35:07 UTC
Created attachment 163071 [details]
Comment 1 Jan Beich freebsd_committer 2015-11-13 01:11:23 UTC
ports r382333 added OPTIONS_EXCLUDE_${OPSYS} support but missed one more place where available options are enumerated. This leads to inconsistency in how option helpers work when used together with OPTIONS_EXCLUDE*.

OPTIONS_EXCLUDE_DragonFly has very few consumers most of which use !${PORT_OPTIONS:MFOO} rather than _OFF helpers. So, test with

  $ make clean all OPSYS=DragonFly -C devel/fb-adb
Comment 2 Mathieu Arnold freebsd_committer 2015-11-13 10:08:51 UTC
This looks good, please commit.
Comment 3 Kubilay Kocak freebsd_committer freebsd_triage 2015-11-13 10:23:17 UTC
Comment on attachment 163071 [details]

Maintainer (portmgr, antoine) approved.
Comment 4 Mathieu Arnold freebsd_committer 2015-11-13 13:28:54 UTC
there are other missing, I'll fix.
Comment 5 Mathieu Arnold freebsd_committer 2015-11-13 13:50:05 UTC
Well, there were no other problems, but I did things a bit differently in the end.
Comment 6 commit-hook freebsd_committer 2015-11-13 13:51:03 UTC
A commit references this bug:

Author: mat
Date: Fri Nov 13 13:50:35 UTC 2015
New revision: 401514
URL: https://svnweb.freebsd.org/changeset/ports/401514

  Refactor the list of all excluded options so that the second place it is
  needed is not forgotten any more.

  PR:		204510
  With hat:	portmgr
  Sponsored by:	Absolight

Comment 7 commit-hook freebsd_committer 2015-11-13 13:51:05 UTC
A commit references this bug:

Author: mat
Date: Fri Nov 13 13:50:45 UTC 2015
New revision: 401515
URL: https://svnweb.freebsd.org/changeset/ports/401515

  Remove this hack, now that the framework is fixed.

  PR:		204510
  Submitted by:	jbeich
  Sponsored by:	Absolight