Bug 204547

Summary: www/npm: fixed default C/C++ compiler in node-gyp gcc -> cc, g++ -> c++, added gmake dependency
Product: Ports & Packages Reporter: Yuri Victorovich <yuri>
Component: Individual Port(s)Assignee: Po-Chuan Hsieh <sunpoet>
Status: Closed FIXED    
Severity: Affects Only Me Keywords: needs-qa, patch
Priority: --- Flags: bugzilla: maintainer-feedback? (sunpoet)
koobs: merge-quarterly?
Version: Latest   
Hardware: Any   
OS: Any   
Bug Depends on:    
Bug Blocks: 204932, 205053, 204578, 204906, 204907    
Attachments:
Description Flags
patch
none
patch none

Description Yuri Victorovich freebsd_committer freebsd_triage 2015-11-14 19:55:25 UTC
Created attachment 163124 [details]
patch
Comment 1 Yuri Victorovich freebsd_committer freebsd_triage 2015-11-14 20:10:36 UTC
Created attachment 163125 [details]
patch

Added gmake runtime dependency, because gyp runs gmake during module 'install' command.
Comment 2 commit-hook freebsd_committer freebsd_triage 2015-12-06 17:52:24 UTC
A commit references this bug:

Author: sunpoet
Date: Sun Dec  6 17:52:06 UTC 2015
New revision: 403137
URL: https://svnweb.freebsd.org/changeset/ports/403137

Log:
  - Add gmake to RUN_DEPENDS
  - Fix default C/C++ compiler in node-gyp
  - Bump PORTREVISION for dependency and package change

  PR:		204547
  Submitted by:	Yuri <yuri@rawbw.com>

Changes:
  head/www/npm/Makefile
  head/www/npm/files/patch-node_modules-node-gyp-gyp-pylib-gyp-generator-make.py
Comment 3 Po-Chuan Hsieh freebsd_committer freebsd_triage 2015-12-06 17:55:29 UTC
Committed. Thanks!