Bug 204760
| Summary: | mail/msmtp: fix configuration for gnome password management (now libsecret) | ||
|---|---|---|---|
| Product: | Ports & Packages | Reporter: | John Hein <jcfyecrayz> |
| Component: | Individual Port(s) | Assignee: | Roman Bogorodskiy <novel> |
| Status: | Closed FIXED | ||
| Severity: | Affects Some People | CC: | jcfyecrayz, novel |
| Priority: | --- | Flags: | bugzilla:
maintainer-feedback?
(novel) novel: merge-quarterly+ |
| Version: | Latest | ||
| Hardware: | Any | ||
| OS: | Any | ||
| Attachments: | |||
--with-gnome-keyring doesn't actually work anymore (as of at least msmtp 1.6.2): configure: WARNING: unrecognized options: --with-gnome-keyring Now it's --with-libsecret. I'm updating the patch for that and updating to use OPTIONS knobs. Comment on attachment 163446 [details] [patch] fix libgnome-keyring port dir Obsolete as per comment 1 Created attachment 163449 [details] [patch] use --with*-libsecret for configure and use config knobs framework As mentioned in comment 1, msmtp now uses libsecret rather than libgnome-keyring. q/a for attachment 163449 [details]:
- passes Q/A tests (DEVELOPER=yes)
- passes portlint
- passes various builds with different options set on 9-stable/i386:
no config & BATCH=1
default config
IDN on/off (verified w/ldd)
LIBSECRET on/off (verified w/ldd)
DOCS on/off with MSMTPQ on/off (verified proper PORTDOCS behavior)
Created attachment 163460 [details]
[patch] r2: use --with*-libsecret for configure and use config knobs framework
Added OPTIONS_SUB=yes instead of manually specifying @comment or not and missing portdocs install.
poudriere testport: passed (9-stable/i386)
Thanks for the patch! Any specific reason not to use NSL_CONFIGURE_ENABLE=nls? Created attachment 163490 [details]
updated libsecret diff
An updated patch that just uses NLS_CONFIGURE_ENABLE and bumps PORTREVISION as dependencies changed.
A commit references this bug: Author: novel Date: Thu Nov 26 22:20:28 UTC 2015 New revision: 402464 URL: https://svnweb.freebsd.org/changeset/ports/402464 Log: mail/msmtp: fix configuration for gnome password management In order to enable password management, now '--with-libsecret' option should be used instead of '--with-gnome-keyring'. So fix configure args and rename the GNOMEKEYRING option to LIBSECRET. Also modernize options usage and bump PORTREVISION due to package change. PR: 204760 (with minor edits) Submitted by: John Hein MFH: 2015Q4 Changes: head/mail/msmtp/Makefile head/mail/msmtp/pkg-plist Re: comment 6 - no reason not to use NSL_CONFIGURE_ENABLE=nls. Thanks. A commit references this bug: Author: novel Date: Tue Dec 8 01:39:27 UTC 2015 New revision: 403246 URL: https://svnweb.freebsd.org/changeset/ports/403246 Log: MFH: r402464 mail/msmtp: fix configuration for gnome password management In order to enable password management, now '--with-libsecret' option should be used instead of '--with-gnome-keyring'. So fix configure args and rename the GNOMEKEYRING option to LIBSECRET. Also modernize options usage and bump PORTREVISION due to package change. PR: 204760 (with minor edits) Submitted by: John Hein Approved by: ports-secteam (feld) Changes: _U branches/2015Q4/ branches/2015Q4/mail/msmtp/Makefile branches/2015Q4/mail/msmtp/pkg-plist |
Created attachment 163446 [details] [patch] fix libgnome-keyring port dir Point to the right directory for the libgnome-keyring library.