Bug 204760 - mail/msmtp: fix configuration for gnome password management (now libsecret)
Summary: mail/msmtp: fix configuration for gnome password management (now libsecret)
Status: Closed FIXED
Alias: None
Product: Ports & Packages
Classification: Unclassified
Component: Individual Port(s) (show other bugs)
Version: Latest
Hardware: Any Any
: --- Affects Some People
Assignee: Roman Bogorodskiy
URL:
Keywords:
Depends on:
Blocks:
 
Reported: 2015-11-23 07:48 UTC by John Hein
Modified: 2015-12-08 01:41 UTC (History)
2 users (show)

See Also:
bugzilla: maintainer-feedback? (novel)
novel: merge-quarterly+

Attachments
[patch] fix libgnome-keyring port dir (376 bytes, patch)
2015-11-23 07:48 UTC, John Hein 		no flags Details | Diff
[patch] use --with*-libsecret for configure and use config knobs framework (3.64 KB, patch)
2015-11-23 09:25 UTC, John Hein 		no flags Details | Diff
[patch] r2: use --with*-libsecret for configure and use config knobs framework (3.67 KB, patch)
2015-11-23 20:24 UTC, John Hein 		no flags Details | Diff
updated libsecret diff (3.74 KB, patch)
2015-11-24 19:32 UTC, Roman Bogorodskiy 		no flags Details | Diff
Show Obsolete (3) View All Add an attachment (proposed patch, testcase, etc.)

Note You need to log in before you can comment on or make changes to this bug.
Description John Hein 2015-11-23 07:48:47 UTC 
Created attachment 163446 [details]
[patch] fix libgnome-keyring port dir

Point to the right directory for the libgnome-keyring library.
Comment 1 John Hein 2015-11-23 08:14:52 UTC 
--with-gnome-keyring doesn't actually work anymore (as of at least msmtp 1.6.2):

configure: WARNING: unrecognized options: --with-gnome-keyring


Now it's --with-libsecret.

I'm updating the patch for that and updating to use OPTIONS knobs.
Comment 2 Kubilay Kocak freebsd_committer freebsd_triage 2015-11-23 08:22:11 UTC 
Comment on attachment 163446 [details]
[patch] fix libgnome-keyring port dir

Obsolete as per comment 1
Comment 3 John Hein 2015-11-23 09:25:15 UTC 
Created attachment 163449 [details]
[patch] use --with*-libsecret for configure and use config knobs framework

As mentioned in comment 1, msmtp now uses libsecret rather than libgnome-keyring.
Comment 4 John Hein 2015-11-23 10:32:26 UTC 
q/a for attachment 163449 [details]:
- passes Q/A tests (DEVELOPER=yes)
- passes portlint
- passes various builds with different options set on 9-stable/i386:
   no config & BATCH=1
   default config
   IDN on/off (verified w/ldd)
   LIBSECRET on/off (verified w/ldd)
   DOCS on/off with MSMTPQ on/off (verified proper PORTDOCS behavior)
Comment 5 John Hein 2015-11-23 20:24:32 UTC 
Created attachment 163460 [details]
[patch] r2: use --with*-libsecret for configure and use config knobs framework

Added OPTIONS_SUB=yes instead of manually specifying @comment or not and missing portdocs install.

poudriere testport: passed (9-stable/i386)
Comment 6 Roman Bogorodskiy freebsd_committer freebsd_triage 2015-11-24 15:40:44 UTC 
Thanks for the patch! Any specific reason not to use NSL_CONFIGURE_ENABLE=nls?
Comment 7 Roman Bogorodskiy freebsd_committer freebsd_triage 2015-11-24 19:32:15 UTC 
Created attachment 163490 [details]
updated libsecret diff

An updated patch that just uses NLS_CONFIGURE_ENABLE and bumps PORTREVISION as dependencies changed.
Comment 8 commit-hook freebsd_committer freebsd_triage 2015-11-26 22:20:55 UTC 
A commit references this bug:

Author: novel
Date: Thu Nov 26 22:20:28 UTC 2015
New revision: 402464
URL: https://svnweb.freebsd.org/changeset/ports/402464

Log:
  mail/msmtp: fix configuration for gnome password management

  In order to enable password management, now '--with-libsecret'
  option should be used instead of '--with-gnome-keyring'.

  So fix configure args and rename the GNOMEKEYRING option to
  LIBSECRET.

  Also modernize options usage and bump PORTREVISION due to
  package change.

  PR:		204760 (with minor edits)
  Submitted by:	John Hein
  MFH:		2015Q4

Changes:
  head/mail/msmtp/Makefile
  head/mail/msmtp/pkg-plist
Comment 9 John Hein 2015-11-27 07:50:20 UTC 
Re: comment 6 - no reason not to use NSL_CONFIGURE_ENABLE=nls.  Thanks.
Comment 10 commit-hook freebsd_committer freebsd_triage 2015-12-08 01:40:01 UTC 
A commit references this bug:

Author: novel
Date: Tue Dec  8 01:39:27 UTC 2015
New revision: 403246
URL: https://svnweb.freebsd.org/changeset/ports/403246

Log:
  MFH: r402464

  mail/msmtp: fix configuration for gnome password management

  In order to enable password management, now '--with-libsecret'
  option should be used instead of '--with-gnome-keyring'.

  So fix configure args and rename the GNOMEKEYRING option to
  LIBSECRET.

  Also modernize options usage and bump PORTREVISION due to
  package change.

  PR:		204760 (with minor edits)
  Submitted by:	John Hein
  Approved by:	ports-secteam (feld)

Changes:
_U  branches/2015Q4/
  branches/2015Q4/mail/msmtp/Makefile
  branches/2015Q4/mail/msmtp/pkg-plist