Bug 205498

Summary: multimedia/ffmpeg: Rename option "LIBV4L" to "V4L"
Product: Ports & Packages Reporter: Yuri Victorovich <yuri>
Component: Individual Port(s)Assignee: Thomas Zander <riggs>
Status: Closed FIXED    
Severity: Affects Only Me CC: portmaster, riggs
Priority: --- Keywords: easy, patch, patch-ready
Version: LatestFlags: bugzilla: maintainer-feedback? (multimedia)
Hardware: Any   
OS: Any   
See Also: https://bugs.freebsd.org/bugzilla/show_bug.cgi?id=205499
Bug Depends on:    
Bug Blocks: 205499    
Attachments:
Description Flags
patch none

Description Yuri Victorovich freebsd_committer freebsd_triage 2015-12-21 21:25:35 UTC
Created attachment 164471 [details]
patch

Every other port uses V4L.

It is beneficial when the user sets one default V4L=on and all relevant ports will switch to V4L support.
Comment 1 Chris Hutchinson 2015-12-21 22:59:12 UTC
(In reply to yuri from comment #0)
> Created attachment 164471 [details]
> patch
> 
> Every other port uses V4L.
> 
> It is beneficial when the user sets one default V4L=on and all relevant
> ports will switch to V4L support.

Hey Yuri. :)

I see you pulled the LIBV4l description:
-LIBV4L_DESC=	Video for Linux support

But didn't replace it with anything.
Maybe:

+V4L_DESC=	Video for Linux support ?

But maybe it's just me. :)

--Chris
Comment 2 Yuri Victorovich freebsd_committer freebsd_triage 2015-12-21 23:39:37 UTC
There is the default description for V4L.
Comment 3 Chris Hutchinson 2015-12-22 00:11:29 UTC
(In reply to yuri from comment #2)
> There is the default description for V4L.

Ahh... Sorry. My bad.
Comment 4 commit-hook freebsd_committer freebsd_triage 2015-12-24 12:48:33 UTC
A commit references this bug:

Author: riggs
Date: Thu Dec 24 12:47:59 UTC 2015
New revision: 404350
URL: https://svnweb.freebsd.org/changeset/ports/404350

Log:
  Update to upstream version 2.8.4

  While on it:
  - Rename option "LIBV4L" to "V4L" to match naming as in other ports [1]

  PR:		205498 [1]
  Submitted by:	yuri@rawbw.com [1]

Changes:
  head/multimedia/ffmpeg/Makefile
  head/multimedia/ffmpeg/distinfo
  head/multimedia/ffmpeg/files/patch-libavcodec-libvpxenc.c