Bug 205789

Summary: mail/postfix-policyd-spf-python: Issues when both py-ipaddr and py-ipaddress are installed
Product: Ports & Packages Reporter: Ken <mayhem30>
Component: Individual Port(s)Assignee: Kubilay Kocak <koobs>
Status: Closed FIXED    
Severity: Affects Many People CC: contact, dbaio, me, neil, python, vlad-fbsd, yasu
Priority: --- Keywords: easy, patch
Version: LatestFlags: me: maintainer-feedback+
me: maintainer-feedback+
Hardware: amd64   
OS: Any   
See Also: https://bugs.freebsd.org/bugzilla/show_bug.cgi?id=205910
https://bugs.freebsd.org/bugzilla/show_bug.cgi?id=206643
https://bugs.freebsd.org/bugzilla/show_bug.cgi?id=206067
Bug Depends on: 205907, 206643    
Bug Blocks:    
Attachments:
Description Flags
proposed patch. vlad-fbsd: maintainer-approval? (me)

Description Ken 2016-01-01 20:53:47 UTC 
The latest update to mail/postfix-policyd-spf-python is broken.

It appears the issue is with having both devel/py-ipaddr and net/py-ipaddress installed.

mail/postfix-policyd-spf-python requires devel/py-ipaddr and the new dependency dns/py-py3dns requires net/py-ipaddress.

I found someone else having the same issue using Red Hat: https://bugzilla.redhat.com/show_bug.cgi?id=1232595

Now the solution over there is to remove py-ipaddr from the system and the dependency on py-ipddr in the mail/postfix-policyd-spf-python package.

As it stands right now, mail/postfix-policyd-spf-python is un-usable with the latest update that now requires mail/py-pyspf (which installs net/py-ipaddress).
Comment 1 Ken 2016-01-01 21:00:48 UTC 
Sorry, the last part should of read :

... is un-usable with the latest update that now requires dns/py-py3dns (which installs net/py-ipaddress).
Comment 2 Yasuhiro Kimura freebsd_committer freebsd_triage 2016-01-04 07:04:22 UTC 
Created attachment 165035 [details]
proposed patch.

This issue is already reported by upstrem BTS.

https://bugs.launchpad.net/pypolicyd-spf/+bug/1495159

According to above entry the source of the issue is not net/py-ipaddr but net/py-ipaddress, and the author says the solution is to use Python 3.

So I propose attached patch.
Comment 3 neil 2016-01-04 18:10:55 UTC 
Can a forced requirement on Python 3 be permitted when there is a ports-wide default of Python 2.7?

Would this be in violation of some policy?
Comment 4 VK 2016-01-04 18:15:38 UTC 
Yasuhiro,

thanks for the patch. Can you confirm it passes Poudriere testport? Does it build and install against Python 3.4 and 3.5?
Comment 5 VK 2016-01-04 18:19:16 UTC 
(In reply to neil from comment #3)

It's okay for ports to require specific Python version, since Python versions can be installed concurrently. The defaults matter when no specific version is preferred. See https://wiki.freebsd.org/DEFAULT_VERSIONS .
Comment 6 Giel van Schijndel 2016-01-04 21:51:22 UTC 
Patch looks good to commit.
Comment 7 VK 2016-01-04 23:55:39 UTC 
(In reply to Giel van Schijndel from comment #6)

Please set maintainer-feedback+ on the issue, and maintainer-approval+ on the patch if you think it's good to go.

However, this does not build against Python 3 because it depends on py-ipaddr which is apparently not ready for 3. That's a separate issue that will have to be dealt with first.

Guys, please confirm with a poudriere test?
Comment 8 Giel van Schijndel 2016-01-05 08:45:37 UTC 
Comment on attachment 165035 [details]
proposed patch.

looks good, but make sure to confirm it actually works
Comment 9 Ken 2016-01-05 19:47:54 UTC 
The only way to fix this is to install Python 3.x?

I already have Python 2.7 installed (required by a few other ports) and would hate to have to install yet another version just to use this one port.

If that's the case, I'll remove it and install the Perl version instead.
Comment 10 Yasuhiro Kimura freebsd_committer freebsd_triage 2016-01-09 11:27:49 UTC 
(In reply to Vladimir Krstulja from comment #4)

Unfortunately the patch cannot be tested because it hits bug of poudriere.
See Bug 206067 for the detail.
Comment 11 Danilo G. Baio freebsd_committer freebsd_triage 2017-07-05 00:21:37 UTC 
This dependency problem was fixed in ports r407273
Comment 12 Kubilay Kocak freebsd_committer freebsd_triage 2017-07-05 05:17:16 UTC 
Correctly set resolution to FIXED, used for issues that are resolved *with* a change (commit). Use Overcome By Events to mean 'superseded' and/or for issues that are resolved *without* a change/commit.

Given this report is not the same as, but is a symptom of underlying bug 206643, correctly set it as a 'Depends On'.

Given I resolved bug 206643, assign it to myself
Comment 13 Kubilay Kocak freebsd_committer freebsd_triage 2017-07-05 05:19:18 UTC 
Move/Add bug 206067 to See Also, instead of Depends On. Latter is for actual blocking issues/bugs