Bug 207051

Summary: www/tinyproxy: Only binds to all (*) interfaces for IPv6, but not IPv4, when "Listen" is disabled (fixed in 1.8.4)
Product: Ports & Packages Reporter: Jason Mann <jason.mann>
Component: Individual Port(s)Assignee: Kurt Jaeger <pi>
Status: Closed FIXED    
Severity: Affects Some People CC: jason.mann, pi
Priority: --- Keywords: patch, patch-ready
Version: LatestFlags: pi: maintainer-feedback-
Hardware: Any   
OS: Any   
Bug Depends on:    
Bug Blocks: 206233    
Attachments:
Description Flags
Patch to update port to 1.8.4
koobs: maintainer-approval+
New patch koobs: maintainer-approval+

Description Jason Mann 2016-02-09 10:24:52 UTC 
- Overview

Tinyproxy defaults to binding to all interfaces if no 'Listen' directive is specified in the configuration file, however version 1.8.3 only binds to all interfaces using IPv6.

- Steps to reproduce

Remove or comment out 'Listen' directive in configuration file.  Start tinyproxy.

- Actual results

Tinyproxy binds to all interfaces using only IPv6:

  # netstat -an | grep 8888 | grep LISTEN
  tcp6       0      0 *.8888                 *.*                    LISTEN

- Expected results

Tinyproxy should bind to all interfaces using both IPv4 and IPv6.

- Additional information

This bug is fixed upstream in version 1.8.4, released on 2014/12/13, as well as adding support for multiple Listen directives for finer grained control of which interfaces Tinyproxy listens on.
Comment 1 Jason Mann 2016-05-13 12:00:56 UTC 
Created attachment 170242 [details]
Patch to update port to 1.8.4

This patch updates the port to 1.8.4 and also uncomments PidFile and LogFile directives in the config file so that the service can be started after the port is installed, remediating bug 206233
Comment 2 Kubilay Kocak freebsd_committer freebsd_triage 2016-07-01 11:18:38 UTC 
Attachment 170242 [details] resolves bug 206233
Comment 3 Kubilay Kocak freebsd_committer freebsd_triage 2016-07-01 11:22:40 UTC 
Comment on attachment 170242 [details]
Patch to update port to 1.8.4

Maintainer timeout, implicit approval

QA (portlint, poudriere) results would be handy
Comment 4 Jason Mann 2016-07-01 15:26:23 UTC 
Created attachment 172005 [details]
New patch

This patch supersedes the previous one.

Source now used in un-processed form (no automake/autoconf already done), so patches included in the port needed changing to work on different files (Makefile.am instead of Makefile.in, and configure.ac instead of configure).
Comment 5 Jason Mann 2016-07-01 15:29:36 UTC 
Portlint output:

FATAL: .svn/wc.db-journal: empty file and should be removed. If it still needs to be there, put a dummy comment to state that the file is intentionally left empty.
WARN: Consider to set DEVELOPER=yes in /etc/make.conf
1 fatal error and 1 warning found.


Assuming that FATAL can be disregarded as it refers to a .svn file.
Comment 6 Kubilay Kocak freebsd_committer freebsd_triage 2016-07-05 09:36:03 UTC 
Comment on attachment 172005 [details]
New patch

This patch is a replacement for the prior patch only modifying the source autoconf files, rather than their processed counterparts, maintainer timeout, implicit approval accordingly
Comment 7 Kubilay Kocak freebsd_committer freebsd_triage 2016-07-06 11:48:28 UTC 
Open to take
Comment 8 Kurt Jaeger freebsd_committer freebsd_triage 2016-07-07 17:41:42 UTC 
testbuilds@work
Comment 9 Kurt Jaeger freebsd_committer freebsd_triage 2016-07-07 18:00:50 UTC 
testbuilds are OK
Comment 10 Jason Mann 2016-07-08 12:25:12 UTC 
I've been having issues with the 1.8.4 build on my system.  Tinyproxy is from time to time becoming unresponsive to requests made to it for several minutes.  It'll then suddenly burst back into life.  Not sure how best to diagnose this.
Comment 11 Kurt Jaeger freebsd_committer freebsd_triage 2016-11-22 17:59:12 UTC 
Committed, thanks! Sorry for the delay!
Comment 12 commit-hook freebsd_committer freebsd_triage 2016-11-22 17:59:46 UTC 
A commit references this bug:

Author: pi
Date: Tue Nov 22 17:58:55 UTC 2016
New revision: 426834
URL: https://svnweb.freebsd.org/changeset/ports/426834

Log:
  www/tinyproxy: update 1.8.3 -> 1.8.4

  - new WWW

  PR:		207051
  Changes:	https://github.com/tinyproxy/tinyproxy/releases
  Submitted by:	jason.mann+freebsd@gmail.com
  Approved by:	sunpoet (maintainer timeout)

Changes:
  head/www/tinyproxy/Makefile
  head/www/tinyproxy/distinfo
  head/www/tinyproxy/files/patch-Makefile.am
  head/www/tinyproxy/files/patch-Makefile.in
  head/www/tinyproxy/files/patch-configure
  head/www/tinyproxy/files/patch-configure.ac
  head/www/tinyproxy/files/patch-etc-Makefile.in
  head/www/tinyproxy/files/patch-src-main.c
  head/www/tinyproxy/pkg-descr
Comment 13 commit-hook freebsd_committer freebsd_triage 2017-01-16 19:25:33 UTC 
A commit references this bug:

Author: pi
Date: Mon Jan 16 19:25:01 UTC 2017
New revision: 431697
URL: https://svnweb.freebsd.org/changeset/ports/431697

Log:
  www/tinyproxy: MAINTAINER back to sunpoet@

  PR:		207051
  Requested by:	sunpoet

Changes:
  head/www/tinyproxy/Makefile