Bug 206233 - www/tinyproxy: Provided config file doesn't set "PidFile" parameter
Summary: www/tinyproxy: Provided config file doesn't set "PidFile" parameter
Status: Closed Overcome By Events
Alias: None
Product: Ports & Packages
Classification: Unclassified
Component: Individual Port(s) (show other bugs)
Version: Latest
Hardware: Any Any
: --- Affects Many People
Assignee: Kurt Jaeger
URL:
Keywords: needs-qa, patch, patch-ready
Depends on: 207051
Blocks:
  Show dependency tree / graph
 
Reported: 2016-01-14 11:32 UTC by Jason Mann
Modified: 2016-12-03 02:49 UTC (History)
1 user (show)

See Also:
pi: maintainer-feedback-

Attachments
Patch to update port to 1.8.4 (1.29 KB, patch)
2016-05-19 10:46 UTC, Jason Mann 		no flags Details | Diff
Show Obsolete (1) View All Add an attachment (proposed patch, testcase, etc.)

Note You need to log in before you can comment on or make changes to this bug.
Description Jason Mann 2016-01-14 11:32:29 UTC 
- Overview:

A new installation of tinyproxy will not start with the default configuration file because the PidFile directive is commented out and the program defaults to a non-existent location.

- Steps to reproduce:

Install www/tinyproxy package.  Attempt to start the service.

- Actual results:

tinyproxy exits immediately.

- Expected results:

tinyproxy should start and continue running as a daemon with sensible default settings.

- Additional information:

Output of tinyproxy when run in debug mode from command line with the default configuration file provided by the package:

  # tinyproxy -d
  tinyproxy: Could not create file /var/run/tinyproxy/tinyproxy.pid: No such file or directory
  tinyproxy: Could not create PID file.

Obviously, this is trivial to fix by uncommenting the PidFile directive in the provided configuration file, but it violates the principle of least astonishment.
Comment 1 Jason Mann 2016-05-13 12:02:52 UTC 
Patch provided for bug 207051 fixes this issue as well.
Comment 2 Jason Mann 2016-05-19 10:46:18 UTC 
Created attachment 170478 [details]
Patch to update port to 1.8.4

Patch updates port to 1.8.4, and uncomments 'PidFile' and 'LogFile' directives in config file so that service can be started with default configuration after installation.
Comment 3 Kubilay Kocak freebsd_committer freebsd_triage 2016-07-01 11:21:14 UTC 
Comment on attachment 170478 [details]
Patch to update port to 1.8.4

Superseded by bug 207051 -> attachment 170242 [details]
Comment 4 Kubilay Kocak freebsd_committer freebsd_triage 2016-07-01 11:21:50 UTC 
Maintainer timeout, implicit approval
Comment 5 Kubilay Kocak freebsd_committer freebsd_triage 2016-12-03 02:49:24 UTC 
Assign to committer that resolved.